[18.0][FIX] helpdesk_mgmt_project: explicitly assign project to task#998
Draft
github-yotech wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
When creating a new task from the
task_idfield on ahelpdesk.ticketform, the task is created as a "Private Task" (assigned to the user's private project) instead of adopting the project already selected on the ticket.Expected Behavior
Any new task created and linked to a ticket should explicitly inherit the
project_idfrom the Helpdesk Ticket.Root Cause
The previous implementation relied solely on the UI passing
default_project_idvia context. However, duplicateproject_idfield definitions in the XML (one hidden, one visible) caused the Odoo 18 Web Client to fail during context evaluation, resulting in the task being created without a project. Furthermore, the backend did not explicitly enforce the project synchronization upon task linkage.Solution
Following OCA guidelines prioritizing Explicit over Implicit behavior:
createandwriteonhelpdesk.ticket. If a task is linked that does not have aproject_id, it is now explicitly assigned the ticket'sproject_id.invisible="1"duplicate field definitions inhelpdesk_ticket_view_formto prevent Web Client evaluation issues.