Skip to content

[19.0][FWD] component: test setup #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OCA-git-bot merged 2 commits into from
Jun 17, 2026
Merged

[19.0][FWD] component: test setup #536

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96d9f26
[IMP] component: improve test setup
SilvioC2C Jun 12, 2026
048c471
[FIX] component: fix test setup
SilvioC2C Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions component/tests/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@ def setUpComponent(cls):
)
)

# pylint: disable=W8106
def setUp(self):
self.setUpComponentRegistryReady()

def setUpComponentRegistryReady(self):
# should be ready only during tests, never during installation
# of addons
Expand All @@ -74,19 +70,9 @@ def setUpClass(cls):
super().setUpClass()
cls.setUpComponent()

# pylint: disable=W8106
def setUp(self):
# resolve an inheritance issue (common.TransactionCase does not call
# super)
common.TransactionCase.setUp(self)
ComponentMixin.setUp(self)
# There's no env on setUpClass of TransactionCase, must do it here.
self.env = self.env(
context=dict(
self.env.context,
components_registry=self._components_registry,
)
)
super().setUp()
self.setUpComponentRegistryReady()


class ComponentRegistryCase:
Expand Down
Loading