[18.0][FIX] mail_brand: Brand not pre-filled in email compose wizard#307
Open
BhaveshHeliconia wants to merge 1 commit into
Open
[18.0][FIX] mail_brand: Brand not pre-filled in email compose wizard#307BhaveshHeliconia wants to merge 1 commit into
BhaveshHeliconia wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opening the "Send Email" composer from a record that has a brand set, the Brand field was not being pre-populated.
The root cause is an API change in mail.compose.message: the res_id integer field was removed and replaced by res_ids, a Text field storing the record IDs as a JSON list. The old code was reading result.get("res_id") which is always None, so the auto-populate logic never ran.
The fix reads res_ids instead and uses odoo's own parse_res_ids helper to extract the active record ID.
The stale else branch that set result["brand_id"] = self.brand_id was also removed — in an @api.model method self carries no record, so this always evaluated to False and was silently overwriting any default_brand_id value passed in context.