Skip to content

[15.0] portal_brand#249

Open
bosd wants to merge 1 commit into
OCA:15.0from
bosd:15.0-portal_brand
Open

[15.0] portal_brand#249
bosd wants to merge 1 commit into
OCA:15.0from
bosd:15.0-portal_brand

Conversation

@bosd
Copy link
Copy Markdown
Contributor

@bosd bosd commented Apr 21, 2025 •
edited
Loading

depends on #247

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 24, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 24, 2025
@bosd bosd force-pushed the 15.0-portal_brand branch from c172c0e to b67e30f Compare September 11, 2025 08:55
@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 14, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 18, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 18, 2026
@bosd bosd force-pushed the 15.0-portal_brand branch from 571d631 to ec9baa4 Compare January 24, 2026 10:50
@bosd bosd marked this pull request as ready for review January 24, 2026 10:50
@bosd
Copy link
Copy Markdown
Contributor Author

bosd commented Jan 24, 2026

@Dranyel-Bosd Can you please review?

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 25, 2026
@BhaveshHeliconia BhaveshHeliconia mentioned this pull request Apr 28, 2026
Closed
BhaveshHeliconia
BhaveshHeliconia suggested changes May 18, 2026
View reviewed changes
Comment thread portal_brand/__init__.py
@@ -0,0 +1 @@
from . import models
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from . import models

Remove non-existant models import from module init

Comment thread portal_brand/__manifest__.py
"author": "Odoo Community Association (OCA), bosd",
"website": "https://github.com/OCA/brand",
"version": "15.0.1.0.0",
"depends": ["mail_brand", "brand"],
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"depends": ["mail_brand", "brand"],
"depends": ["mail_brand", "brand", "portal"],

Add portal module dependancy

@BhaveshHeliconia
Copy link
Copy Markdown
Contributor

BhaveshHeliconia commented May 18, 2026

@bosd When we've multiple brands with logo set, then how this module functions and which logo will be displayed when portal user do login?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bosd @BhaveshHeliconia