feat: Rust API safety, serialization, filtering, and upstream bug fixes#1
Merged
Merged
Conversation
…ypes Cherry-picked from upstream PR NVIDIA#1869 (rapidsai/cuvs). Introduces Index<'a> with DatasetOwnership enum (Borrowed/Owned) across brute_force, cagra, ivf_flat, and ivf_pq. Adds build() for borrowed datasets (compiler enforces lifetime) and build_owned() for self-contained indexes. Fixes use-after-free when C library dereferences freed dataset. Original author: zbennett10 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… indexes Cherry-picks CAGRA serialization from upstream PR NVIDIA#1840 (zbennett10), adapted for the Index<'a> lifetime API from PR NVIDIA#1869. Adds new Nuvai-authored serialize/deserialize methods for IVF-PQ and IVF-Flat, following the same pattern (CString filename, FFI call to cuvsIvfPqSerialize/Deserialize and cuvsIvfFlatSerialize/Deserialize). Includes round-trip tests for CAGRA and IVF-PQ serialization, plus hnswlib export test for CAGRA. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Cherry-picked from upstream PR NVIDIA#1781. Fixes cudaErrorIllegalAddress under concurrent search by ensuring per-thread distance buffer indexing stays within bounds. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Cherry-picked from upstream PR NVIDIA#1084. Uses float accumulator for FP16 distance computation to prevent overflow when distance values exceed FP16 range. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Cherry-picked from upstream PR NVIDIA#1890. Removes incorrect assertion that triggered crashes in valid IVF-Flat fused kernel use cases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Cherry-picked from upstream PR NVIDIA#1922. Adds default member initializers for public header structs (distance, grammian, ball_cover, hnsw, vamana, spectral_embedding) to prevent undefined behavior when fields are unset. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Cherry-picked from upstream PR NVIDIA#1851. Tracks kernel function pointer changes and re-applies shared memory attribute when CAGRA search switches between kernel variants, preventing silent performance degradation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Cherry-picked from upstream PR NVIDIA#1842. Adds C API functions to control dataset attachment during CAGRA build, halving VRAM usage for large datasets. Also adds cuvsCagraUpdateDataset for replacing the dataset after build without rebuilding the graph. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… batch sizes Cherry-picked from upstream PR NVIDIA#1841. Fixes silent recall drop when AUTO algorithm selector switches from MULTI_CTA to SINGLE_CTA at large batch sizes with search_width > 1. Includes regression benchmark and test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Cherry-picked from upstream PR NVIDIA#1861 (fixes NVIDIA#1859). Adds builder pattern with validation for CAGRA, IVF-Flat, IVF-PQ, and Vamana index/search params. Invalid parameters now return errors instead of silently causing GPU crashes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Cherry-picked from upstream PR NVIDIA#1478, adapted for Index<'a> lifetime API from PR NVIDIA#1869. Adds Filter trait and implementations (NoFilter, Bitset, Bitmap) in Rust, updates search() signatures across CAGRA, IVF-PQ, and IVF-Flat to accept Optional<&dyn Filter>. Includes C API filter plumbing, C tests for filtered search, and Go/Python bindings updates. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks and adapts 9 unmerged upstream PRs from rapidsai/cuvs, plus Nuvai-authored IVF-PQ/IVF-Flat serialization, into a single integration branch for Knuckles' cuVS dependency.
Rust API improvements
Index<'a>withDatasetOwnershipenum prevents use-after-free when C library dereferences freed dataset pointerscuvsIvfPqSerialize/cuvsIvfFlatSerializeFiltertrait (NoFilter, Bitset, Bitmap) for CAGRA, IVF-PQ, IVF-Flat search across C/Rust/Go/PythonBug fixes (C++/CUDA)
VRAM optimization
Upstream PR references
Test plan
cargo testinrust/cuvs/(requires CUDA toolkit)🤖 Generated with Claude Code