fix: stop the example cards from overriding their own link role - #42
Open
thejesh23 wants to merge 1 commit into
Open
fix: stop the example cards from overriding their own link role#42thejesh23 wants to merge 1 commit into
thejesh23 wants to merge 1 commit into
Conversation
Each card in the examples rail is an <a href> carrying role="listitem", which replaces the implicit link role. Assistive tech announced the fourteen cards as plain list items, and they were missing from the links rotor. Dropping the ARIA list roles restores link semantics; the rail keeps its label via role="group". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@thejesh23 is attempting to deploy a commit to the Together AI Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41
role="listitem"on the fourteen<a class="ex-card">elements replaced their implicitlinkrole, so assistive tech announced them as list items and left them out of the links rotor.Drops the ARIA list roles; the rail keeps its label via
role="group". Markup and CSS are otherwise untouched.Accessibility tree after the change: