fix: fall back to a real theme when data-theme is unknown - #40
Open
thejesh23 wants to merge 1 commit into
Open
Conversation
An unrecognised ?theme= value (or a stale localStorage entry) passed the resolver untouched and was written back to storage, so the picker stayed desynced on every later visit. Validate the attribute against THEMES.
|
@thejesh23 is attempting to deploy a commit to the Together AI Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38
The theme resolver's last fallback read
root.dataset.themeback, which the pre-paint script had already set from an unvalidated?theme=/ localStorage value. The bad value survived and was persisted, leaving the picker desynced on every later visit.Validates the attribute against
THEMESbefore using it, so an unknown value lands onhumand self-heals stale storage.Verified locally:
/?theme=totally-not-a-theme→data-theme="hum", storage"hum", Hum dot pressedlocalStorageentry → corrected on next load/?theme=carnival→ unchanged (Carnival, 18 / 20, marquee hero)