Skip to content

Unpin Oceananigans, allow more GPUCompiler versions#800

Merged
giordano merged 11 commits into
mainfrom
mg/unpin-reactant
Jun 24, 2026
Merged

Unpin Oceananigans, allow more GPUCompiler versions#800
giordano merged 11 commits into
mainfrom
mg/unpin-reactant

Conversation

@giordano

Copy link
Copy Markdown
Member

Follow up to #799: I merged that PR quickly once I verified Reactant tests were finishing in a finite time to get CI working back, so that now we can do experiments with less pressure. The only combination I didn't try in #799 was pinning only GPUCompiler, let's see if this is sufficient to get decent CI times

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@giordano

Copy link
Copy Markdown
Member Author
│ [2760] signal 8 (1): Floating point exception
│ in expression starting at /__w/Breeze.jl/Breeze.jl/test/reactant/advection_diffusion_ad.jl:116
└ Allocations: 437508571 (Pool: 437485389; Big: 23182); GC: 219

Fun 😅

In any case, JuliaGPU/GPUCompiler.jl#861 may have resolved the massive slowdown, let's see if that does the trick.

@giordano giordano marked this pull request as draft June 24, 2026 09:15
@giordano

Copy link
Copy Markdown
Member Author

In any case, JuliaGPU/GPUCompiler.jl#861 may have resolved the massive slowdown, let's see if that does the trick.

Apparently it did not 😕

@giordano

Copy link
Copy Markdown
Member Author
│ [2760] signal 8 (1): Floating point exception
│ in expression starting at /__w/Breeze.jl/Breeze.jl/test/reactant/advection_diffusion_ad.jl:116
└ Allocations: 437508571 (Pool: 437485389; Big: 23182); GC: 219

Fun 😅

Ok, Reactant v0.2.267 has this issue with GPUCompiler v1.22.1-3 (and with v1.22.4 it just hangs). CC @Pangoraw

@giordano giordano changed the title Unpin Oceananigans and Reactant Unpin Oceananigans, allow more GPUCompiler versions Jun 24, 2026
@giordano giordano marked this pull request as ready for review June 24, 2026 12:11
@giordano giordano merged commit 587faa6 into main Jun 24, 2026
8 checks passed
@giordano giordano deleted the mg/unpin-reactant branch June 24, 2026 12:52
@macmccallum

Copy link
Copy Markdown
Collaborator

I am noticing a massive slowdown in compilation today. Any chance these changes are causing this? @giordano

@giordano

Copy link
Copy Markdown
Member Author

What workloads are you talking about? This is only relevant for Reactant, I don't think we're aware of other significant compilation latency regressions elsewhere. Also, this change is to avoid large compilation latency in Reactant.

@macmccallum

Copy link
Copy Markdown
Collaborator

I was using ExplicitTimeStepping against the baroclinic wave example. This may be some intermittent issue. I can't seem to replicate the stalling. Disregard this.

glwagner added a commit that referenced this pull request Jun 26, 2026
Oceananigans 0.109 renamed the open-boundary classification NormalFlow → Open, so
`is_active_open_bc` (in the compressible acoustic substep loop) failed to compile
with `UndefVarError: NormalFlow`, blocking ALL compressible SplitExplicit runs on
the resolved Oceananigans (0.109.2). This is a pre-existing breakage from the
Oceananigans unpin (#800), independent of the vector-invariant work, surfaced here
because the baroclinic-wave example exercises SplitExplicit.

Minimal rename to unblock. NOTE: a broader cleanup remains (NormalFlowBoundaryCondition
→ OpenBoundaryCondition in Breeze.jl exports and terrain_compressible_physics.jl,
currently only a load-time warning); that and the overall Oceananigans-version
strategy should be confirmed separately.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants