Unpin Oceananigans, allow more GPUCompiler versions#800
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Fun 😅 In any case, JuliaGPU/GPUCompiler.jl#861 may have resolved the massive slowdown, let's see if that does the trick. |
Apparently it did not 😕 |
Ok, Reactant v0.2.267 has this issue with GPUCompiler v1.22.1-3 (and with v1.22.4 it just hangs). CC @Pangoraw |
This reverts commit cb41201.
|
I am noticing a massive slowdown in compilation today. Any chance these changes are causing this? @giordano |
|
What workloads are you talking about? This is only relevant for Reactant, I don't think we're aware of other significant compilation latency regressions elsewhere. Also, this change is to avoid large compilation latency in Reactant. |
|
I was using ExplicitTimeStepping against the baroclinic wave example. This may be some intermittent issue. I can't seem to replicate the stalling. Disregard this. |
Oceananigans 0.109 renamed the open-boundary classification NormalFlow → Open, so `is_active_open_bc` (in the compressible acoustic substep loop) failed to compile with `UndefVarError: NormalFlow`, blocking ALL compressible SplitExplicit runs on the resolved Oceananigans (0.109.2). This is a pre-existing breakage from the Oceananigans unpin (#800), independent of the vector-invariant work, surfaced here because the baroclinic-wave example exercises SplitExplicit. Minimal rename to unblock. NOTE: a broader cleanup remains (NormalFlowBoundaryCondition → OpenBoundaryCondition in Breeze.jl exports and terrain_compressible_physics.jl, currently only a load-time warning); that and the overall Oceananigans-version strategy should be confirmed separately. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Follow up to #799: I merged that PR quickly once I verified Reactant tests were finishing in a finite time to get CI working back, so that now we can do experiments with less pressure. The only combination I didn't try in #799 was pinning only GPUCompiler, let's see if this is sufficient to get decent CI times