fix(mailpit): independent replicaCount + nodeSelector/tolerations#33
Merged
Conversation
The chart-native mailpit sink hardcoded replicas: 1 and inherited the xnat pod's nodeSelector/tolerations (.Values.nodeSelector), so it could not scale to 0 when idle and was pinned to xnat's tainted/sized pool. Expose mailpit.replicaCount (default 1) and mailpit.nodeSelector/.tolerations (default empty) so an orchestrator can scale the sink 0<->1 per test run and place it on the general node pool, independent of the xnat StatefulSet. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
andrey-embarklabs
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the chart-native mailpit sink independently schedulable + scalable:
mailpit.replicaCount(default1) — set0to scale the sink down when idle.mailpit.nodeSelector/mailpit.tolerations(default empty) — place the sink on its own node pool instead of inheriting the xnat pod's.Why
Adopting the native mailpit for test installs, we want the sink ephemeral (scaled to 0 between runs, scaled up by the test orchestrator) and on the general node pool — not occupying the xnat pod's tainted/sized nodes. Today
replicas: 1is hardcoded andnodeSelector/tolerationscome from.Values.nodeSelector/.tolerations(the xnat pod's).Behavior change
Existing
mailpit.enabledusers: the sink no longer inherits.Values.nodeSelector/.tolerations; defaults are empty (general pool). Setmailpit.nodeSelector/.tolerationsto restore pinning.Verified
helm template … --set mailpit.enabled=true --set mailpit.replicaCount=0 --set mailpit.nodeSelector.…rendersreplicas: 0and the nodeSelector/tolerations correctly.🤖 Generated with Claude Code