ci: render charts with their ci/*-values.yaml fixtures in lint and kubeconform#29
Merged
andrey-embarklabs merged 1 commit intoJun 15, 2026
Conversation
…beconform The template + kubeconform step renders each chart with no values file, so a chart that adds a required-credential guard (e.g. a required database password) fails to render even though it ships a ci/ fixture that satisfies the guard. Load each chart's ci/*-values.yaml fixtures (chart-testing convention) in both the lint and template steps, falling back to defaults when a chart has none.
kathrynalpert
approved these changes
Jun 15, 2026
kathrynalpert
left a comment
Contributor
There was a problem hiding this comment.
Fixtures are matched by ci/*-values.yaml, would this be true for all relevant files, or do we need to document the expectation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
helm template + kubeconformstep renders each chart with no values file (helm template ci "${chart}"). That works until a chart adds a render-timerequiredguard on a credential. PR #21 adds exactly such a guard (cnpg.cluster.credentials.password is required) and shipshelm/xnat/ci/default-values.yamlto satisfy it, but the workflow never loads that fixture, so the render fails:(
helm lintpasses because it does not hard-fail onrequired; only the kubeconform render does.)This loads each chart's
ci/*-values.yamlfixtures (the chart-testing convention) in both the lint and template/kubeconform steps, falling back to default values when a chart has no fixture. Charts without a fixture render exactly as before.Verified with the CI-pinned toolchain (helm, kubeconform v0.7.0, actionlint 1.7.7 + shellcheck
--severity=error):Note on ordering: merge this before #21. Once #21's guard is on main, the
chart-lintpush run on main needs this fixture-loading to stay green.