feat(novel): preserve description line breaks with shared formattedText#121
Draft
mrissaoussama wants to merge 1 commit into
Draft
feat(novel): preserve description line breaks with shared formattedText#121mrissaoussama wants to merge 1 commit into
mrissaoussama wants to merge 1 commit into
Conversation
…t util
Many novel sources built descriptions with Jsoup's text(), which collapses
<br>/<p> and newlines into single spaces. Add Element.formattedText() to
keiyoushi.utils (promoted from the madaranovel/lightnovelworld helpers) and
switch the affected sources to it so paragraph breaks survive.
Sources: lightnovelworld, lightnovelwp, lightnovelwpnovel, galaxynovels,
asiannovel, honeyfeed, libread, lightnoveltranslation, lncrawler, lnori,
mtlreader, mvlempyr, novelable, novelbuddy, novelfire, novelsknight, pawread,
penguinsquad, ranobes, readnovelmtl, royalroad, scribblehub, vynovel.
novelbuddy also drops the catch{} that masked its chapterListParse errors as an
empty list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t util
Many novel sources built descriptions with Jsoup's text(), which collapses
/
and newlines into single spaces. Add Element.formattedText() to keiyoushi.utils
Sources: lightnovelworld, lightnovelwp, lightnovelwpnovel, galaxynovels, asiannovel, honeyfeed, libread, lightnoveltranslation, lncrawler, lnori, mtlreader, mvlempyr, novelable, novelbuddy, novelfire, novelsknight, pawread, penguinsquad, ranobes, readnovelmtl, royalroad, scribblehub, vynovel.
Checklist:
extVersionCodevalue inbuild.gradlefor individual extensionsoverrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsisNsfw = trueflag inbuild.gradlewhen appropriateidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extension