feat(acp): opt-in profile tool policy for full-capability hosts#70326
Open
joelbrilliant wants to merge 4 commits into
Open
feat(acp): opt-in profile tool policy for full-capability hosts#70326joelbrilliant wants to merge 4 commits into
joelbrilliant wants to merge 4 commits into
Conversation
Add acp.tool_policy so ACP hosts can use a profile's local CLI tool configuration instead of the coding-only hermes-acp default. Profile mode resolves tools through the canonical platform resolver, applies the same policy on session restore, and ignores host MCP expansion so the host cannot broaden the selected profile. Default remains hermes-acp for editor compatibility. No config version bump.
Some clean-env runners lack the optional ACP package; skip cleanly.
alt-glitch
added
type/feature
The new acp.tool_policy default was a single-field CONFIG_SCHEMA category, which fails test_no_single_field_categories. Merge acp into agent like other one-field sections (mcp, computer_use, onboarding).
Explain profile vs hermes-acp tool policy so remote ACP hosts (Buzz and similar) can match interactive CLI tools without changing editor defaults.
7 tasks
Contributor
Author
Review requestOpt-in only. Editors keep the coding What this adds acp:
tool_policy: profile # full profile tools for remote ACP hosts
Why Live proof Related open PRs (complementary, not duplicates)
Happy to adjust naming or defaults if maintainers prefer a different config shape. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
acp.tool_policyso ACP hosts (Buzz, Zed, and other full-capability hosts) can use a Hermes profile's local CLI tool configuration instead of the coding-onlyhermes-acpdefault.hermes-acp(editor-compatible, no behaviour change)acp.tool_policy: profileresolves tools via the canonical_get_platform_toolspath againstplatform_toolsets.cli(or explicitplatform_toolsets.acpwhen set)acp.tool_policyinto the agent config tabWhy
Remote ACP hosts that attach an existing full Hermes profile need the profile's configured tools (skills, memory, kanban, cron, delegation, …), not the reduced coding toolset. This is generic ACP surface — no host-specific code.
Live dogfood: Buzz Desktop owner-only Rocky DM with full profile tools after setting
acp.tool_policy: profile(companion Buzz PR #2633).Relationship to other open PRs
platform_toolsets.acpalwaystool_policy: profilewe already honour explicitplatform_toolsets.acp, else mirror CLIagent.disabled_toolsets_get_platform_tools, which already applies global disablesA deeper first-class product integration with Buzz (beyond ACP stdio) is still best owned by Nous Research if desired later. This PR unblocks full-capability hosts now without breaking editors.
Test plan
scripts/run_tests.sh tests/acp/test_tool_policy.py -q(13 passed)hermes-acp+ profile MCP