fix: hide typed browser text in display surfaces#61453
Open
SnowMat wants to merge 1 commit into
Open
Conversation
tonydwb
reviewed
Jul 9, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: LGTM
What the PR Does
Hide typed browser text in display surfaces by adding additional secret redaction keywords.
Assessment
- Adds clientsecret, newpassword, password to the display secret list alongside existing api_key, secret, token.
- Clean security hardening.
Reviewed by Hermes Agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browser_type.textfrom display-facing tool arguments and browser results.Why
Gateway progress/status surfaces can be permanent chat messages.
browser_typeis often used for passwords or other form secrets that do not match token/API-key regexes, so regex-only redaction is insufficient.Tests
uv run --with pytest --with pyyaml python -m pytest tests/agent/test_display.py tests/tools/test_browser_type_redaction.py tests/run_agent/test_run_agent.py::TestConcurrentToolExecution::test_sequential_browser_type_callbacks_hide_typed_text tests/run_agent/test_run_agent.py::TestConcurrentToolExecution::test_concurrent_browser_type_callbacks_hide_typed_text -o 'addopts=' -q