fix(desktop): extend remote cwd boot timeout#61449
Open
konsisumer wants to merge 1 commit into
Open
Conversation
tonydwb
reviewed
Jul 9, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: LGTM
What the PR Does
Extend remote cwd boot timeout to prevent startup failures on slow remote environments.
Assessment
- Small test-only change. Clean fix, well-scoped.
Reviewed by Hermes Agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Per the reporter's clarification on July 9, 2026, the remote desktop path can still fail after
Remote Hermes backend is readywith a renderer-sidehermes:apitimeout on currentmain. The desktop boot burst had already been widened for config/model/profile calls, but the remotedesktopDefaultCwd()probe still used the Electron bridge's default 15s timeout. This PR moves that remote/api/fs/default-cwdrequest ontoSTARTUP_REQUEST_TIMEOUT_MS, so the post-connect boot path does not fail early on the leftover short timeout.How to test
npm --workspace apps/desktop exec -- vitest run src/lib/desktop-fs.test.ts src/hermes.test.ts.Remote Hermes backend is ready, the renderer can complete the remote default-CWD probe without tripping the old 15shermes:apitimeout.What platforms tested on
Fixes #38061