Skip to content

fix(gateway): respect explicit Feishu enabled:false in config.yaml (fixes #47804) #61441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kuangmi-bit wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −2
Open

fix(gateway): respect explicit Feishu enabled:false in config.yaml (fixes #47804) #61441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions gateway/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1856,8 +1856,15 @@ def _enable_from_env(platform: Platform) -> PlatformConfig:
if feishu_app_id and feishu_app_secret:
if Platform.FEISHU not in config.platforms:
config.platforms[Platform.FEISHU] = PlatformConfig()
config.platforms[Platform.FEISHU].enabled = True
config.platforms[Platform.FEISHU].extra.update({
# Respect explicit enabled: false in config.yaml — don't force-enable
# when the user intentionally disabled the platform (mirrors Slack at L1596).
# _enabled_explicit is set in _merge_platform_map when "enabled" appears in
# a top-level platform YAML entry or platforms.<name> map entry.
feishu_config = config.platforms[Platform.FEISHU]
enabled_was_explicit = bool(feishu_config.extra.get("_enabled_explicit", False))
if not feishu_config.enabled and not enabled_was_explicit:
feishu_config.enabled = True
feishu_config.extra.update({
"app_id": feishu_app_id,
"app_secret": feishu_app_secret,
"domain": getenv("FEISHU_DOMAIN", "feishu"),
Expand Down