Skip to content

fix: resolve incomplete search results in sessions tab#61427

Open
iborazzi wants to merge 6 commits into
NousResearch:mainfrom
iborazzi:fix/sessions-search-full-set
Open

fix: resolve incomplete search results in sessions tab#61427
iborazzi wants to merge 6 commits into
NousResearch:mainfrom
iborazzi:fix/sessions-search-full-set

Conversation

@iborazzi

@iborazzi iborazzi commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?
This PR resolves issue #61418. The current implementation of the Sessions tab search was page-local, meaning it only filtered the currently loaded set of 20 sessions instead of searching across the entire database. This fix updates the search logic to render full search results directly when a query is active, mapping them to the expected SessionInfo format.

Related Issue
Fixes #61418

Type of Change
[x] 🐛 Bug fix (non-breaking change that fixes an issue)

[ ] ✨ New feature (non-breaking change that adds functionality)

[ ] 🔒 Security fix

[ ] 📝 Documentation update

[ ] ✅ Tests (adding or improving test coverage)

[ ] ♻️ Refactor (no behavior change)

[ ] 🎯 New skill (bundled or hub)

Changes Made
web/src/pages/SessionsPage.tsx:

Introduced searchResultSessions as the primary list source when a search query is active.

Implemented mapping logic to convert SessionSearchResult objects into SessionInfo shape, providing necessary fallbacks for fields not present in search results (e.g., is_active, message_count).

Decoupled search rendering from local pagination.

How to Test
Navigate to the Sessions tab in the dashboard.

Enter a search term that exists in multiple sessions across the database (e.g., "hindsight").

Verify that the UI displays all matching sessions, rather than only those present in the first page of the default session list.

Checklist
[x] I've read the Contributing Guide

[x] My commit messages follow Conventional Commits

[x] I searched for existing PRs to make sure this isn't a duplicate

[x] My PR contains only changes related to this fix

[ ] I've run pytest tests/ -q and all tests pass

[ ] I've added tests for my changes

[x] I've tested on my platform: Windows 11

Documentation & Housekeeping
[x] I've considered cross-platform impact — N/A

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/dashboard Web dashboard / control panel UI (dashboard/, landing) labels Jul 9, 2026
@iborazzi iborazzi requested a review from a team July 9, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/dashboard Web dashboard / control panel UI (dashboard/, landing) P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sessions tab search only returns matches from the current page, not the full session set

2 participants