fix(state): prefer pysqlite3 for session search FTS#61175
Open
martinramos002-bot wants to merge 1 commit into
Open
fix(state): prefer pysqlite3 for session search FTS#61175martinramos002-bot wants to merge 1 commit into
martinramos002-bot wants to merge 1 commit into
Conversation
martinramos002-bot
force-pushed
the
fix/session-search-pysqlite3-fts
branch
from
b8ba3d3 to
ca00412
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Hermes’ session search reliability on Linux by preferring pysqlite3-binary (when available) to ensure FTS5 + trigram support even when the distro-provided stdlib sqlite3 is built without those extensions, while keeping a stdlib fallback.
Changes:
- Add a Linux-only dependency on
pysqlite3-binaryto improve SQLite feature availability for session-search FTS. - In
hermes_state.py, attempt to import and usepysqlite3as thesqlite3backend (with stdlib fallback) and broaden OperationalError handling to cover both backends. - Add a TypeError compatibility fallback in WAL setup to avoid failing initialization when cross-backend cursor/connection types are incompatible (notably under certain test shims).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Adds a Linux-only pysqlite3-binary dependency to improve SQLite extension availability for session search. |
| hermes_state.py | Switches SQLite backend preference to pysqlite3 when available and broadens error handling around WAL/FTS initialization paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+29
to
+52
| try: | ||
| import pysqlite3 as sqlite3 # type: ignore[import-not-found] | ||
| # Some already-imported modules (notably tests) may hold a reference to the | ||
| # stdlib sqlite3 module object. Mirror the DB-API symbols we rely on so new | ||
| # connections/cursor subclasses in those modules use the same C extension | ||
| # type family as Hermes itself. | ||
| for _name in ( | ||
| "connect", | ||
| "Connection", | ||
| "Cursor", | ||
| "Row", | ||
| "Error", | ||
| "DatabaseError", | ||
| "OperationalError", | ||
| "IntegrityError", | ||
| "ProgrammingError", | ||
| ): | ||
| if hasattr(sqlite3, _name): | ||
| setattr(_stdlib_sqlite3, _name, getattr(sqlite3, _name)) | ||
| sys.modules["sqlite3"] = sqlite3 | ||
| _SQLITE_OPERATIONAL_ERRORS = (sqlite3.OperationalError, _stdlib_sqlite3.OperationalError) | ||
| except ModuleNotFoundError: # pragma: no cover - depends on local Python build | ||
| sqlite3 = _stdlib_sqlite3 | ||
| _SQLITE_OPERATIONAL_ERRORS = (sqlite3.OperationalError,) |
Comment on lines
+401
to
+405
| except TypeError as exc: | ||
| # pysqlite3 can be active in production while tests deliberately | ||
| # monkeypatch stdlib-sqlite connection subclasses. Those cross-module | ||
| # C extension types are not always interchangeable; skip WAL rather | ||
| # than failing SessionDB initialization in that compatibility shim. |
martinramos002-bot
force-pushed
the
fix/session-search-pysqlite3-fts
branch
from
ca00412 to
d8a6a1e
Compare
alt-glitch
added
type/feature
Collaborator
Related: #41033 (the canonical open fix, which adds a |
martinramos002-bot
force-pushed
the
fix/session-search-pysqlite3-fts
branch
3 times, most recently
from
c8ae7d3 to
49c05ba
Compare
tonydwb
reviewed
Jul 9, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Comment (prior automated review noted)
This PR has a prior automated COMMENT review. No new issues found.
Looks Good
- Prefers pysqlite3 for session search FTS — appropriate performance/portability fix
- No security concerns
martinramos002-bot
force-pushed
the
fix/session-search-pysqlite3-fts
branch
from
49c05ba to
4fedd7c
Compare
martinramos002-bot
force-pushed
the
fix/session-search-pysqlite3-fts
branch
from
4fedd7c to
c218f31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pysqlite3-binaryon Linux/x86_64, where upstream publishes wheels, so session-search FTS5/trigram support is present even if the distro stdlib SQLite lacks itpysqlite3uv.lockin sync and avoids forcing source builds on Linux/arm64Test plan
uv lock --checkpython -m pytest tests/test_hermes_state.py -q -o addopts=''The diff contains only generic dependency/backend handling and synthetic tests from the existing suite.