fix(desktop): avoid local profile REST backend spawns#61033
Draft
embwl0x wants to merge 1 commit into
Draft
Conversation
d21da36 to
bbb93d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #61023.
Hermes One can start an extra isolated dashboard backend for a local non-primary profile during startup because the Electron
hermes:apiproxy treated everyrequest.profileas a backend-process routing key. Profile-scoped startup/config/session reads then callensureBackend(profile), which launches a pooled--profile <name> dashboard/servebackend even though the primary machine dashboard can serve local profiles through?profile=.This keeps ordinary local-profile REST on the primary backend and appends
?profile=<name>to the proxied path instead. Per-profile remote overrides and app-global remote mode still route through profile descriptors so remote hosts keep working. Live chat sockets still use the existing lazy secondary backend path; this only changes REST routing.Refresh note
Rebuilt onto current
mainafter the desktop app moved from CommonJS Electron files to TypeScript/ESM. The routing helper and IPC coverage now live in the current.tsfiles.Duplicate / overlap check
61023 in:title,bodyreturned no open PRs.Verification
cd apps/desktop && node --import tsx --test electron/connection-config.test.ts electron/profile-delete-respawn.test.ts— 57 passednpm --prefix apps/desktop run typecheckgit diff --check origin/main..HEADgitleaks git --log-opts='origin/main..HEAD' --redact .— no leaks found