fix(desktop): recover backend ready port from recent log output#60986
Open
ParaWheeler wants to merge 1 commit into
Open
fix(desktop): recover backend ready port from recent log output#60986ParaWheeler wants to merge 1 commit into
ParaWheeler wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
ParaWheeler
force-pushed
the
fix/desktop-ready-announcement-race
branch
from
f62a838 to
54af8ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a Desktop local-backend startup race condition where the backend can print
HERMES_BACKEND_READY port=<port>before the port-announcement watcher is attached. In that case the line is visible indesktop.log, but Desktop still times out waiting for the announcement.This teaches the backend-ready parser to accept Desktop-prefixed log lines and passes recent Hermes log output into the watcher so a late-attached watcher can recover the already-announced port.
Fixes #60323.
Test plan
node --test apps/desktop/electron/backend-ready.test.cjsgit diff --check origin/main..HEADnode --check apps/desktop/electron/backend-ready.cjsnode --check apps/desktop/electron/main.cjsnode --check apps/desktop/electron/backend-ready.test.cjs