Add TryGetValue to RowRef{T}, SubrowRef{T}

[Haselnussbomber]

Just for supporting the TryGet pattern in the typed RowRef/SubrowRef.
The untyped RowRef already has it.

CC: @WorkingRobot

[WorkingRobot]

Is there a reason why we should have this interface? This feels more like a potential footgun rather than a nice-to-have.

[Haselnussbomber]

I currently have this as extension method and am using this to return early.
Not sure what footgun you mean?

public bool CanTryOn(ItemHandle item)
{
    if (!TryGetItem(item, out var itemRow))
        return false;

    // not equippable, Waist or SoulCrystal => false
    if (itemRow.EquipSlotCategory.RowId is 0 or 6 or 17)
        return false;

    // any OffHand that's not a Shield => false
    if (itemRow.EquipSlotCategory.RowId is 2 && itemRow.FilterGroup != (int)ItemFilterGroup.Shield)
        return false;

    if (!_playerState.IsLoaded)
        return false;

    var race = _playerState.Race.RowId;
    if (race == 0)
        return false;

    if (!itemRow.EquipRestriction.TryGetRow(out var equipRaceCategoryRow)) // <--- here
        return false;

    if (!equipRaceCategoryRow.Races[(int)race - 1])
        return false;

    return _playerState.Sex switch
    {
        Sex.Female => equipRaceCategoryRow.Female,
        Sex.Male => equipRaceCategoryRow.Male,
        _ => false
    };
}

Though I coded it a bit differently:

extension<T>(RowRef<T> rowRef) where T : struct, IExcelRow<T>
{
    public bool TryGetRow(out T row)
    {
        if (rowRef.IsValid)
        {
            row = rowRef.Value;
            return true;
        }

        row = default;
        return false;
    }
}

If the user is disregarding the return value when using the TryGet pattern, that's entirely on them. It's the same as not checking HasValue.

I also don't mind to continue using my extension method (rewritten to the one PRd), if I have to.
Just thought this might be useful.

[NotAdam]

looks good to me, not sure where the footgun is here

[WorkingRobot]

I suppose so, its fine if someone needs that exact interface.