feat: align just ci with CI pipeline#11
Merged
Merged
Conversation
- Add fmt recipe (cargo fmt --all -- --check) - Add --all-features flag to check, lint, and test recipes - Add doc recipe (RUSTDOCFLAGS="-D warnings" cargo doc ...) - Add msrv recipe (cargo +1.85 check, standalone — not part of ci) - Update ci recipe to chain: fmt lint test deny doc - Fix pre-commit hook activation comment: cargo setup -> just setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
just ciintroduced in #8 did not fully match.github/workflows/ci.yml. A PR could passjust cilocally and still fail on CI.Gaps closed:
cargo fmt --all -- --check--all-featureson check/clippy/testcargo docwithRUSTDOCFLAGS="-D warnings"Related Issue
Closes #10
Changes
fmtrecipe —cargo fmt --all -- --check; added to thecichain--all-features— added tocheck,lint, andtestrecipesdocrecipe —RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --document-private-items --all-features; added tocichainmsrvrecipe —cargo +1.85 check --workspace --all-targets --all-features; standalone, not inci(requires a separate toolchain install)cichain — now runsfmt lint test deny doc, matching thecijob inci.yml.githooks/pre-commit— fix activation comment:cargo setup→just setupChecklist
just cipasses locallyCHANGELOG.mdupdated (if user-facing change)