Skip to content

nordvpnlite fix wait for start#1782

Open
tomasz-grz wants to merge 2 commits into
mainfrom
nordvpnlite_restart_test
Open

nordvpnlite fix wait for start#1782
tomasz-grz wants to merge 2 commits into
mainfrom
nordvpnlite_restart_test

Conversation

@tomasz-grz
Copy link
Copy Markdown
Contributor

@tomasz-grz tomasz-grz commented May 22, 2026

Problem

There is a race condition between TelioContext::new() and handle_exit_node_connection():

  1. handle_exit_node_connection() starts making API calls.
  2. TelioContext::new() calls set_ip() -> /etc/init.d/network reload and disrupts the network stack.
  3. Current in flight API calls can fail.

Solution

  1. Move handle_exit_node_connection() to run after TelioContext::new() completes.
  2. Broaden retry logic (exponential backoff for all API calls).
  3. Add additional DNS logs to restart test.

☑️ Definition of Done checklist

  • Commit history is clean (requirements)
  • README.md is updated
  • Functionality is covered by unit or integration tests

@tomasz-grz tomasz-grz self-assigned this May 22, 2026
@tomasz-grz tomasz-grz force-pushed the nordvpnlite_restart_test branch from b5c00b5 to 6a45f48 Compare May 26, 2026 11:49
@tomasz-grz tomasz-grz changed the title Wait for start nordvpnlite fix wait for start May 26, 2026
@tomasz-grz tomasz-grz marked this pull request as ready for review May 26, 2026 11:50
@tomasz-grz tomasz-grz requested a review from a team as a code owner May 26, 2026 11:50
@tomasz-grz tomasz-grz force-pushed the nordvpnlite_restart_test branch from 6a45f48 to ffae11c Compare May 27, 2026 09:51
Copy link
Copy Markdown
Contributor

@djkarwowski djkarwowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left just one comment, but overall looks good to me

+1

Comment thread nat-lab/tests/nordvpnlite.py Outdated
Copy link
Copy Markdown
Contributor

@mathiaspeters mathiaspeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lcruz99
Copy link
Copy Markdown
Contributor

lcruz99 commented May 29, 2026

this looks a nice improvement, however would be nice to add some logs or ticket ID to the PR, besides the usual commit history cleaning before merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants