-
Notifications
You must be signed in to change notification settings - Fork 1
script checking for standard EUOUAE lyrics and consistent tones #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
igneus
wants to merge
2
commits into
Nocturnale-Romanum:main
Choose a base branch
from
igneus:euouae_check
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| # Accepts as arguments file or directory paths, | ||
| # checks all gabc files containing antiphons | ||
| # for standard EUOUAE lyrics and tones. | ||
|
|
||
| import os | ||
| import os.path | ||
| import sys | ||
|
|
||
| import arpeggio | ||
| from music21 import converter, volpiano | ||
| from music21.text import assembleLyrics | ||
| import chant21 | ||
| from chant21.gabc.converter import AlterationWarning | ||
|
|
||
| euouae_tones = {} | ||
|
|
||
|
|
||
| class Skip(RuntimeError): | ||
| pass | ||
|
|
||
|
|
||
| def _check(filename, verbose): | ||
| if not filename.endswith('.gabc'): | ||
| raise Skip('not a gabc') | ||
| if '_' in filename: | ||
| raise Skip('submitter (not selected) version') | ||
|
|
||
| if verbose: | ||
| print('checking {}'.format(filename)) | ||
|
|
||
| try: | ||
| chant = converter.parse(filename) | ||
| except (arpeggio.NoMatch, AlterationWarning) as e: | ||
| print('ERROR {}: chant21 cannot parse ({})'.format(filename, e)) | ||
| return | ||
|
|
||
| metadata = chant.editorial.metadata | ||
| office_part = metadata.get('office-part') | ||
| if office_part != 'an': | ||
| raise Skip('not an antiphon ({})'.format(office_part)) | ||
|
|
||
| errors = [] | ||
|
|
||
| last_section = chant.sections[-1] | ||
| lyrics = assembleLyrics(last_section) | ||
| has_euouae = 'E U O U A E.' in lyrics | ||
| # TODO: is there a rule which ones have EUOUAE and which Et sic finiatur? | ||
| if not has_euouae and 'Et sic finiátur.' not in lyrics: | ||
| errors.append('unexpected euouae lyrics "{}"'.format(lyrics)) | ||
|
|
||
| mode = metadata.get('mode') | ||
| if mode is None: | ||
| errors.append('mode missing') | ||
| elif mode not in euouae_tones: | ||
| if verbose: | ||
| print('differentia {}: setting euouae from {} as standard' | ||
| .format(mode, filename)) | ||
| if not has_euouae: | ||
| print('warning: the tone accepted as standard has' | ||
| ' less-standard EUOUAE lyrics') | ||
| euouae_tones[mode] = volpiano.fromStream(last_section) | ||
| elif volpiano.fromStream(last_section) != euouae_tones[mode]: | ||
| # TODO: further normalization is required to correctly compare | ||
| # EUOUAEs with Et sic finiatur's | ||
| errors.append('mode {}, expected {}, got {}' | ||
| .format(mode, euouae_tones[mode], | ||
| volpiano.fromStream(last_section))) | ||
|
|
||
| if len(errors) > 0: | ||
| print('ERROR {}: {}'.format(filename, '; '.join(errors))) | ||
| elif verbose: | ||
| print('OK {}'.format(filename)) | ||
|
|
||
|
|
||
| def check(filename, verbose=False): | ||
| try: | ||
| return _check(filename, verbose) | ||
| except Skip as e: | ||
| if verbose: | ||
| print('skip {}: {}'.format(filename, e)) | ||
|
|
||
|
|
||
| for path in sys.argv[1:]: | ||
| if os.path.isdir(path): | ||
| for root, dirs, files in os.walk(path): | ||
| for f in files: | ||
| check(os.path.join(root, f)) | ||
| else: | ||
| check(path) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EUOUAE is replaced with Et sic finiatur if and only if the GP is omitted at the end of the psalm, which occurs only in Tenebrae (and other hours in the Triduum) and in O.Def.
There are antiphons that I had to duplicate (they are soft-linked through the database website of nocturnale.marteo.fr) because they are used in a context with GP and in another without (e.g. Tenebrae antiphons also used in Our Lady of Sorrows).