Skip to content

nixos/emacs: don't restartIfChanged#539755

Open
Atemu wants to merge 1 commit into
NixOS:masterfrom
Atemu:nixos/emacs-no-restart
Open

nixos/emacs: don't restartIfChanged#539755
Atemu wants to merge 1 commit into
NixOS:masterfrom
Atemu:nixos/emacs-no-restart

Conversation

@Atemu

@Atemu Atemu commented Jul 8, 2026

Copy link
Copy Markdown
Member

Fixes #535449

This probably started happening with the rust rewrite of the switcher also restarting user units now.

Things done

Fixes NixOS#535449

This probably started happening with the rust rewrite of the switcher also
restarting user units now.
@Atemu Atemu added the 6.topic: emacs Text editor label Jul 8, 2026
@Atemu Atemu requested a review from jian-lin July 8, 2026 23:57
@jian-lin

jian-lin commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

This probably started happening with the rust rewrite of the switcher also restarting user units now.

That's good news!


Is it too much to ask to add a regression test for this 😄?

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 9, 2026

@jian-lin jian-lin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I did not test it

s-t-c behavior change is from #507588

If you want to add a regression test, #333955 has an example of how to run switch-to-configuration in a NixOS test. If not, let me know and I will merge it.

environment.sessionVariables.EDITOR = lib.mkIf cfg.defaultEditor (lib.mkOverride 900 "emacseditor");
};

meta.doc = ./emacs.md;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to become the maintainer of this module?

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: emacs Text editor 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

emacs.service gets restarted when changed

2 participants