Skip to content

onlyoffice-documentserver: use icu78#537160

Merged
raboof merged 1 commit into
NixOS:masterfrom
raboof:onlyoffice-documentserver-icu
Jul 3, 2026
Merged

onlyoffice-documentserver: use icu78#537160
raboof merged 1 commit into
NixOS:masterfrom
raboof:onlyoffice-documentserver-icu

Conversation

@raboof

@raboof raboof commented Jun 30, 2026

Copy link
Copy Markdown
Member

This is needed so that doctrenderer uses the same version of icu as the nodejs.libv8 . This is a little scary because it's a different version of icu than boost is built with, but seems to work out in practice. After #520553 this should ideally be in sync again.

Fixes #536824

Things done

This is needed so that doctrenderer uses the same version of icu
as the nodejs.libv8 . This is a little scary because it's a different
version of icu than boost is built with, but seems to work out in
practice. After NixOS#520553 this should ideally be in sync again.

Fixes NixOS#536824
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Jun 30, 2026
@timhae

timhae commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 537160
Commit: f9f60a4608798c2bf37208562dbdcf2ddfa59e61


x86_64-linux

✅ 1 package built:
  • onlyoffice-documentserver

aarch64-linux

✅ 1 package built:
  • onlyoffice-documentserver

@vcunat

vcunat commented Jul 1, 2026

Copy link
Copy Markdown
Member

Beware that on the current staging-next #535855 nodejs uses icu 77 again 🤕 So after this merges, I expect we revert it on staging-next.

@raboof

raboof commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Beware that on the current staging-next #535855 nodejs uses icu 77 again 🤕 So after this merges, I expect we revert it on staging-next.

Ah, I hadn't seen that, thanks ;) . So after merging this to master, I'd wait for master to be merged into staging-next again, and then PR the revert to that? (probably I'd revert only the first two changes and keep the last one in case we want to override icu again in the future)

@raboof raboof added this pull request to the merge queue Jul 3, 2026
Merged via the queue into NixOS:master with commit 9dab67c Jul 3, 2026
35 of 37 checks passed
@raboof raboof deleted the onlyoffice-documentserver-icu branch July 3, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: onlyoffice-documentserver

3 participants