[Backport release-26.05] stdenv/problems: only run problem if it's not ignored#535856
Merged
Conversation
(cherry picked from commit 5c89ab8)
(cherry picked from commit b88fba2)
…edicate (cherry picked from commit 5616e3d)
The stats may be lying to me when they say that this saves 1.86% of attrset lookups, and `?` may just not be accurately tracked. But at worst, performance will stay the same, since the check will fail for all non-broken packages. And who knows, maybe it does help, by nature of not checking the value! (cherry picked from commit 753e43c)
kind and name are more likely to stay the same. Doing this allows us to cache the kind and name when calling the handler for a problem. (cherry picked from commit 41bafcb)
…application (cherry picked from commit 0b30474)
A package failing an automatic problem (of which there's currently only one) is rare. A package having meta.problems specified is even rarer. Inlining the getName call to its two usages saves a thunk in the vast, vast majority of cases, and I consider it to be worth it. (cherry picked from commit 85e32af)
13 tasks
nixpkgs-ci
Bot
added
10.rebuild-darwin: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-26.05, triggered by a label in #519600.Before merging, ensure that this backport is acceptable for the release.
Even as a non-committer, if you find that it is not acceptable, leave a comment.
Tip
If you maintain all packages touched by this pull request, and they are all located under
pkgs/by-name/*, you can comment@NixOS/nixpkgs-merge-bot mergeto automatically merge this PR using thenixpkgs-merge-bot.