nixos/systemd: generate boot random seed with config esp path#535538
Open
5aaee9 wants to merge 1 commit into
Open
nixos/systemd: generate boot random seed with config esp path#5355385aaee9 wants to merge 1 commit into
5aaee9 wants to merge 1 commit into
Conversation
dramforever
requested changes
Jun 26, 2026
dramforever
left a comment
Contributor
There was a problem hiding this comment.
Also, please send this to staging-nixos instead of staging-next.
Pull requests will only be accepted into staging-next when there is an active pending staging-next to master merge, generally for fixes for the current staging-next only. See https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#staging. This is not a fix for staging-next, AFAICT, and you're half a day late for the previous staging-next #534570.
8f73ced to
721dc0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixed systemd-boot when your efi path is not standard path (like /boot/firmware).
Ref: #461676, https://github.com/systemd/systemd/blob/087b0ebb61b9eb6843e844d31dbe96157a95da0e/src/shared/find-esp.c#L436-L477
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.