testers.hasPkgConfigModules: Fix meta propagation#534949
Merged
Merged
Conversation
Needs to forward `nonTeamMaintainers` instead of `maintainers`, because the latter is autopopulated from the former, which in case of teams means all teams members would be added as well. This is what caused an update to curlMinimal to request individual team members instead of the team itself: NixOS#534906
nixpkgs-ci
Bot
added
10.rebuild-darwin: 0
balsoft
approved these changes
Jun 26, 2026
nixpkgs-ci
Bot
added
the
12.approvals: 1
ethancedwards8
approved these changes
Jun 29, 2026
nixpkgs-ci
Bot
added
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to forward
nonTeamMaintainersinstead ofmaintainers, because the latter is autopopulated from the former, which in case of teams means all teams members would be added as well.This is what caused an update to curlMinimal to request individual team members instead of just the team itself: #534906
Things done
nix-instantiate --eval -A tests.pkg-config.defaultPkgConfigPackages.libcurl.meta.nonTeamMaintainersnow only contains the single non-team maintainer of libcurl.