cudaPackages.libnvshmem: default withNccl to nccl.meta.available#532039
Merged
Conversation
`withNccl` defaults to `true`, unconditionally adding `nccl` to `buildInputs`. This is problematic on platforms where NCCL is unavailable, such as pre-Thor Jetson (Orin), where `nccl.meta.available` is `false` due to its `badPlatforms` assertion. In such cases, libnvshmem would still pull the unavailable `nccl` into its closure, leading to an eval-time error. We are changing the default to `nccl.meta.available` to make libnvshmem skip NCCL automatically on platforms where NCCL is unsupported. We preserving the existing behaviour everywhere else (x86_64-linux, Thor Jetson) where `nccl.meta.available` is `true`. Note that this guard has already been added to other CUDA modules such as `cudaPackages.cudss` in NixOS#437723.
nixpkgs-ci
Bot
added
10.rebuild-darwin: 0
Contributor
|
nixpkgs-ci
Bot
added
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withNcclcurrently defaults totrue, unconditionally addingnccltobuildInputs.This is problematic on platforms where NCCL is unavailable, such as pre-Thor Jetson (Orin), where
nccl.meta.availableisfalsedue to itsbadPlatformsassertion. In such cases, libnvshmem would still pull the unavailablencclinto its closure, leading to an eval-time error.We are changing the default to
nccl.meta.availableto make libnvshmem skip NCCL automatically on platforms where NCCL is unsupported. We preserving the existing behaviour everywhere else (x86_64-linux, Thor Jetson) wherenccl.meta.availableistrue.Note that this guard has already been added to other CUDA modules such as
cudaPackages.cudssin #437723.cudaCapabilities = [ "8.7" ];)passthru.tests.nixpkgs-reviewon this PR. See [nixpkgs-review usage]../result/bin/.