Skip to content

[Backport staging-26.05] curl: backport performance patch#525953

Merged
Scrumplex merged 1 commit into
staging-26.05from
backport-522574-to-staging-26.05
May 31, 2026
Merged

[Backport staging-26.05] curl: backport performance patch#525953
Scrumplex merged 1 commit into
staging-26.05from
backport-522574-to-staging-26.05

Conversation

@nixpkgs-ci

@nixpkgs-ci nixpkgs-ci Bot commented May 30, 2026

Copy link
Copy Markdown
Contributor

Bot-based backport to staging-26.05, triggered by a label in #522574.

Before merging, ensure that this backport is acceptable for the release.

Even as a non-committer, if you find that it is not acceptable, leave a comment.

Tip

If you maintain all packages touched by this pull request, and they are all located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this PR using the nixpkgs-merge-bot.

@Scrumplex @github-actions
curl: backport performance patch
99edca1 
curl/curl@2a2104f

See https://curl.se/mail/distros-2026-05/0000.html

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
(cherry picked from commit 06028a8)
@nixpkgs-ci nixpkgs-ci Bot requested a review from Scrumplex May 30, 2026 12:58
@nixpkgs-ci nixpkgs-ci Bot mentioned this pull request May 30, 2026
Merged
14 tasks
@nixpkgs-ci nixpkgs-ci Bot requested review from a team, balsoft, infinisil and pyrox0 May 30, 2026 13:04
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 4.workflow: backport This targets a stable branch labels May 30, 2026
@Scrumplex Scrumplex linked an issue May 30, 2026 that may be closed by this pull request
curl: 8.20 causes 100% CPU consumption in nheko #525926
Closed
4 tasks
Scrumplex
Scrumplex approved these changes May 31, 2026
View reviewed changes

@Scrumplex Scrumplex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 525953 --package curl --package curlMinimal
Commit: 99edca13d244d3020cf906c5bf0a1cf5ff7e53a6

x86_64-linux

✅ 2 packages built:
  • curl
  • curlMinimal

@Scrumplex Scrumplex added this pull request to the merge queue May 31, 2026
Merged via the queue into staging-26.05 with commit 1be26e7 May 31, 2026
34 checks passed
@Scrumplex Scrumplex deleted the backport-522574-to-staging-26.05 branch May 31, 2026 16:12
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 31, 2026
@balsoft balsoft moved this from Needs Review to Reviewed in Nixpkgs security review Jun 1, 2026
@Atemu

Atemu commented Jun 23, 2026

Copy link
Copy Markdown
Member

This broke lix on 26.05; why was this backported?

@Atemu

Atemu commented Jun 23, 2026

Copy link
Copy Markdown
Member

On second thought, it was not obvious that this would cause breakage and "small" bugfixes like what the patch intends to do are well within what is acceptable for backports.

I think the most critical error here was that the patch landed in stable via staging-next-26.05 before staging-next landed it to master. We need some safeguards around this and I can't think of any satisfactory "easy" solution to this problem..

@ethorsoe

ethorsoe commented Jun 24, 2026

Copy link
Copy Markdown

The issue was known, I guess noone picked up the patch override for lix #528906 (comment) or any other solution including dropping the patch completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes
@balsoft balsoft Awaiting requested review from balsoft
@infinisil infinisil Awaiting requested review from infinisil
@pyrox0 pyrox0 Awaiting requested review from pyrox0

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 4.workflow: backport This targets a stable branch 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

Nixpkgs security review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

curl: 8.20 causes 100% CPU consumption in nheko

4 participants

@Atemu @ethorsoe @Scrumplex @balsoft