Skip to content

python3Packages.sympy: build from GitHub sources, cleanup, add GaetanLepage to maintainers#522237

Merged
mweinelt merged 2 commits into
NixOS:stagingfrom
GaetanLepage:fix/sympy
May 20, 2026
Merged

python3Packages.sympy: build from GitHub sources, cleanup, add GaetanLepage to maintainers#522237
mweinelt merged 2 commits into
NixOS:stagingfrom
GaetanLepage:fix/sympy

Conversation

@GaetanLepage

@GaetanLepage GaetanLepage commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Things done

  • python3Packages.sympy: build from GitHub sources, cleanup
  • python3Packages.sympy: add GaetanLepage to maintainers

Fixes #517946 (comment).

@nixpkgs-ci nixpkgs-ci Bot requested review from 7c6f434c, collares and timokau May 20, 2026 13:50
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels May 20, 2026
@GaetanLepage GaetanLepage requested a review from mweinelt May 20, 2026 13:52
@GaetanLepage

GaetanLepage commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 522237 --package python3Packages.torchvision
Commit: db738de1ef7bacf19d46f56b7a8a448a0a87291a

x86_64-linux

✅ 1 package built:
  • python3Packages.torchvision

@GaetanLepage

GaetanLepage commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

@mweinelt @vcunat would it be fine to merge that into master?
I know the build count is unpleasant, but it fixes pretty important packages.

@mweinelt mweinelt added this pull request to the merge queue May 20, 2026
Merged via the queue into NixOS:staging with commit e0cac2e May 20, 2026
27 checks passed
@GaetanLepage GaetanLepage deleted the fix/sympy branch May 20, 2026 18:03
@GaetanLepage GaetanLepage mentioned this pull request May 20, 2026
Merged
14 tasks
@vcunat

vcunat commented May 21, 2026

Copy link
Copy Markdown
Member

Rebuild: linux 1211, darwin 1072

That doesn't seem so high to me. And part of these rebuilds were failing already and get fixed by this, I think.

@GaetanLepage

GaetanLepage commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

Rebuild: linux 1211, darwin 1072

That doesn't seem so high to me. And part of these rebuilds were failing already and get fixed by this, I think.

Sure. I wanted to make sure and not slowing you guys too much.
We merged it into master yesterday.

@vcunat

vcunat commented May 21, 2026

Copy link
Copy Markdown
Member

OK, I'm catching up after half a day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c
@collares collares Awaiting requested review from collares
@timokau timokau Awaiting requested review from timokau
@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GaetanLepage @vcunat @mweinelt