nixos/k3s,rke2: clean up manifests via /etc on config changes#520433
Open
yajo wants to merge 1 commit into
Open
nixos/k3s,rke2: clean up manifests via /etc on config changes#520433yajo wants to merge 1 commit into
yajo wants to merge 1 commit into
Conversation
nixpkgs-ci
Bot
requested review from
a team,
maevii,
rorosen,
stefan-bordei and
zimbatm
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
yajo
force-pushed
the
k3s-manifest-removal
branch
from
59ce69a to
799b1ad
Compare
yajo
changed the title
rorosen
reviewed
May 25, 2026
rorosen
left a comment
rorosen
left a comment
Contributor
There was a problem hiding this comment.
I like the idea, this is a good improvement. It should have been done like this from the beginning tbh. Unfortunately, k3s didn't follow symlinked manifest directories back then.
However, since previous symlinks will remain in the manifest directory, users could end up with conflicting manifest contents. There should be a migration guide on how to remove previous symlinks, e.g. in the release notes.
Please check also formatting
maevii
suggested changes
Jun 14, 2026
Contributor
Author
|
Hi there! Thanks for the reviews. Hold on while I attend the suggestions please.
Yes, the policy was merged some days after I opened the PR, I didn't know about that back then. |
yajo
force-pushed
the
k3s-manifest-removal
branch
from
799b1ad to
924e6b1
Compare
Manifests are now managed declaratively through a linkFarm in the Nix store: - Static symlink: manifests/nixos → linkFarm in Nix store - k3s/rke2 scan subdirectories recursively, pick up changes within 15s When manifests are removed from the config, the linkFarm derivation changes, the activation script updates the symlink, and the stale files disappear naturally — no dangling symlinks. @moduon MT-14138
nixpkgs-ci
Bot
added
2.status: merge conflict
yajo
force-pushed
the
k3s-manifest-removal
branch
from
924e6b1 to
24444a4
Compare
yajo
commented
Jun 18, 2026
yajo
left a comment
yajo
left a comment
Contributor
Author
There was a problem hiding this comment.
All comments attended.
- Formatting fixed.
- Test merged with
auto-deploy.nix - Release notes.
/etcintermediate symlink removed
Contributor
Author
|
IIUC CI failures are not related to my changes. |
nixpkgs-ci
Bot
removed
the
2.status: merge conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, when a manifest was removed from NixOS configuration, its symlink
still remained inside
/var/lib/rancher/k3s/server/manifests.Manifests are now managed declaratively through a linkFarm in the Nix store:
manifests/nixos→ linkFarm in Nix storeWhen manifests are removed from the config, the linkFarm derivation
changes, the activation script updates the symlink, and the stale files
disappear naturally — no dangling symlinks.
@moduon MT-14138