Skip to content

cerberus: re-enable install-check tests#515118

Merged
vbgl merged 1 commit into
NixOS:masterfrom
siraben:siraben/cerberus-test
Apr 30, 2026
Merged

cerberus: re-enable install-check tests#515118
vbgl merged 1 commit into
NixOS:masterfrom
siraben:siraben/cerberus-test

Conversation

@siraben

@siraben siraben commented Apr 30, 2026

Copy link
Copy Markdown
Member

Re-enables the cerberus tests disabled in #512807. The failures came from Dune 3.21's deprecated_coq_lang warning polluting stderr via dune exec. Setting WITH_CERB=cerberus runs the installed binary directly. Verified: 188 passed, 0 failed.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot requested a review from RossSmyth April 30, 2026 18:08
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Apr 30, 2026

@RossSmyth RossSmyth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RossSmyth

Copy link
Copy Markdown
Contributor

@NixOS/nixpkgs-merge-bot merge

@Elec3137

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 515118
Commit: df6d7e2a9c6635b3d177bc333e92e13b4e7ff0be


x86_64-linux

✅ 1 package built:
  • cerberus

@vbgl vbgl added this pull request to the merge queue Apr 30, 2026
@nixpkgs-ci

nixpkgs-ci Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

@RossSmyth wants to merge this PR.

Requirements to merge this PR with @NixOS/nixpkgs-merge-bot merge:

  • ✅ PR targets a development branch.
  • ✅ PR touches only files of packages in pkgs/by-name/.
  • ✅ PR is at least one of:
  • ✅ PR is not a draft
  • ✅ RossSmyth is a member of @NixOS/nixpkgs-maintainers.
  • ✅ RossSmyth is a maintainer of all touched packages on the master branch.

✔️ Enabled Auto Merge (#306934)

Tip

Sometimes GitHub gets stuck after enabling Auto Merge. In this case, leaving another approval should trigger the merge.

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Apr 30, 2026
Merged via the queue into NixOS:master with commit d67f00f Apr 30, 2026
34 checks passed
@siraben siraben deleted the siraben/cerberus-test branch April 30, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants