Skip to content

ovito: add wrapGAppsHook3 to nativeBuildInputs#507382

Merged
pbsds merged 2 commits into
NixOS:masterfrom
ginsanches:ovito-wrapgappshook3
Apr 19, 2026
Merged

ovito: add wrapGAppsHook3 to nativeBuildInputs#507382
pbsds merged 2 commits into
NixOS:masterfrom
ginsanches:ovito-wrapgappshook3

Conversation

@ginsanches

@ginsanches ginsanches commented Apr 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Added wrapGAppsHook3 to the native build inputs. This is necessary to add the required gsettings schemas for gtk3 to the XDG_DATA_DIRS environment variable. The program otherwise crashes when trying to access the file chooser on Gnome with the error that org.gtk.Settings.FileChooser is not installed.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! labels Apr 6, 2026
@ginsanches ginsanches force-pushed the ovito-wrapgappshook3 branch from a84523b to 9c2c560 Compare April 6, 2026 21:44
chillcicada
chillcicada reviewed Apr 7, 2026
View reviewed changes
Comment thread pkgs/by-name/ov/ovito/package.nix
Comment thread pkgs/by-name/ov/ovito/package.nix
@ilkecan ilkecan mentioned this pull request Apr 7, 2026
Open
13 tasks
@twhitehead

twhitehead commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Thanks @ginsanches. This looks pretty good to me with @chillcicada suggestion for the recommend way to handle double wrapped apps. I guess the one outstanding question would be the very recent work in #507455 that would appear to make this not required any more.

@ilkecan, what are you thought on this. Do you think we should hold back on this one as #507455 is likely to be merged in the very near future, or would it make sense to go ahead with this for now and then undo it later once/if #507455 is merged (where it was suggested that such a follow up should take place after merger)?

Thanks!

@ilkecan

ilkecan commented Apr 7, 2026

Copy link
Copy Markdown
Member

Do you think we should hold back on this one as #507455 is likely to be merged in the very near future ...

I don't know what is the procedure to merge something like #507455 and how long it would take, or how long it takes for staging to be merged into master afterwards.

So my personal opinion would be: #507455 shouldn't block this or similar PRs, if they can deliver fixes to the users quicker; it should be relatively easy to track down these commits/PRs to revert in the future when the time comes.

twhitehead
twhitehead suggested changes Apr 8, 2026
View reviewed changes

@twhitehead twhitehead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ginsanches I am good to approve this if you can incorporate @chillcicada's suggestion. Thanks!

twhitehead
twhitehead approved these changes Apr 8, 2026
View reviewed changes

@twhitehead twhitehead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me now. Thanks very much @ginsanches and @chillcicada! 👍

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Apr 8, 2026
chillcicada
chillcicada approved these changes Apr 9, 2026
View reviewed changes

@chillcicada chillcicada left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you squash the commits

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 9, 2026
@das-g das-g mentioned this pull request Apr 13, 2026
Open
13 tasks
das-g added a commit to das-g/nixpkgs that referenced this pull request Apr 13, 2026
@das-g
kmymoney: add gappsWrapperArgs to qtWrapperArgs
72abb27 
so that attempting to export a report (as well as presumably any other
action requiring a file chooser dialog) will work again also on GNOME,
rather than crashing with
	(kmymoney:26393): GLib-GIO-ERROR **: 16:18:43.780: Settings schema ‘org.gtk.Settings.FileChooser’ is not installed

This change was authored following the example of
NixOS#507382
as of 1e50738,
though with the addition of TODO comments to remind me to revert this
once the underlying problem has been solved globally in nixpkgs.
@pbsds pbsds added this pull request to the merge queue Apr 19, 2026
Merged via the queue into NixOS:master with commit 20ca79f Apr 19, 2026
33 of 35 checks passed
@ginsanches ginsanches deleted the ovito-wrapgappshook3 branch April 26, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CHN-beta CHN-beta Awaiting requested review from CHN-beta
2 more reviewers
@twhitehead twhitehead twhitehead approved these changes
@chillcicada chillcicada chillcicada approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ginsanches @twhitehead @ilkecan @chillcicada @pbsds