neovim[-unwrapped]: 0.12.0 -> 0.12.1#507289
Conversation
There was a problem hiding this comment.
The PR's base branch is set to master, and this PR causes 512 rebuilds.
Please consider whether this PR causes a mass rebuild according to our conventions.
If it does cause a mass rebuild, please change the base branch to the right base branch for your changes (probably staging).
If it does not cause a mass rebuild, this message can be ignored.
|
|
Grug always seems to fail since the breaking changes in 0.12 |
|
Seems to build fine here for 0.12.0. I can recreate the failure in 0.12.1. Ironic for a patch version. |
|
The |
Interesting, I remember that the 0.12 had trouble with it too but got resolved. |
|
I think that's fair. Just add a skip with a TODO referencing the upstream PR |
|
The I've opened a PR to update the grug-far.nvim screenshot tests: MagicDuck/grug-far.nvim#577 But they look brittle to me and could easily break if the Neovim UI changes again. |
Should we do it in this PR? |
|
|
And here's the temporary fix for catppuccin-nvim: #507389 |
|
lgtm! |
40015fb to
ce2e8e7
Compare
|
|
Looks like I misspelled the |
ce2e8e7 to
c02cfe2
Compare
|
Changelog: neovim/neovim@7ac5a26
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.