cuda_nvcc: also patch math_functions.hpp for glibc 2.42#498678
Merged
GaetanLepage merged 1 commit intoMar 22, 2026
Conversation
The existing glibc 2.42 compatibility patch fixes function signatures in math_functions.h but misses math_functions.hpp, which has the same rsqrt/sinpi/cospi functions wrapped in __func__() macros. Without throw() annotations on these, C++ compilation fails when glibc 2.42 declares the same functions with throw().
nixpkgs-ci
Bot
added
10.rebuild-linux: 11-100
Contributor
|
What did you do to verify it/downstream consumers still correctly build and link? |
ConnorBaker
approved these changes
Mar 11, 2026
ConnorBaker
left a comment
ConnorBaker
left a comment
Contributor
There was a problem hiding this comment.
@GaetanLepage so long as torch/vllm build like we discussed, this is good to merge!
nixpkgs-ci
Bot
added
12.approvals: 1
Member
Author
only private stuff thus far, happy to try to address breakages if there are any |
GaetanLepage
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The existing glibc 2.42 compatibility patch (added in #484031) fixes function signatures in
math_functions.hbut missesmath_functions.hpp, which has the samersqrt/sinpi/cospifunctions wrapped in__func__()macros. Withoutthrow()annotations on these, C++ compilation against CUDA headers fails when glibc 2.42 declares the same functions withthrow().Things done