Skip to content

python3Packages.bitsandbytes: fix cuda build #483507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GaetanLepage wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −9
Draft

python3Packages.bitsandbytes: fix cuda build #483507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions pkgs/development/python-modules/bitsandbytes/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
scipy,
trove-classifiers,

# passthru
bitsandbytes,

cudaSupport ? torch.cudaSupport,
cudaPackages ? torch.cudaPackages,
rocmSupport ? torch.rocmSupport,
Expand All @@ -26,12 +29,9 @@
}:

let
pname = "bitsandbytes";
version = "0.49.1";

brokenConditions = lib.attrsets.filterAttrs (_: cond: cond) {
"CUDA and ROCm are mutually exclusive" = cudaSupport && rocmSupport;
"CUDA is not targeting Linux" = cudaSupport && !stdenv.hostPlatform.isLinux;
"CUDA is not targeting Linux" = cudaSupport && !effectiveStdenv.hostPlatform.isLinux;
};

inherit (cudaPackages) cudaMajorMinorVersion;
Expand Down Expand Up @@ -72,15 +72,18 @@ let
name = "cuda-redist-${cudaMajorMinorVersion}";
paths = cuda-common-redist;
};
effectiveStdenv = if cudaSupport then cudaPackages.backendStdenv else stdenv;
in
buildPythonPackage {
inherit pname version;
buildPythonPackage.override { stdenv = effectiveStdenv; } (finalAttrs: {
pname = "bitsandbytes";
version = "0.49.1";

pyproject = true;

src = fetchFromGitHub {
owner = "bitsandbytes-foundation";
repo = "bitsandbytes";
tag = version;
tag = finalAttrs.version;
hash = "sha256-nNhxDJITXNIZMXuZdzpF5dl1K1kFEVQ0gbTqZnOf/sI=";
};

Expand Down Expand Up @@ -196,16 +199,21 @@ buildPythonPackage {
updateScript = gitUpdater {
ignoredVersions = "continuous-release.*";
};

gpuCheck = bitsandbytes.overridePythonAttrs {
requiredSystemFeatures = [ "cuda" ];
doCheck = true;
};
};

meta = {
description = "8-bit CUDA functions for PyTorch";
homepage = "https://github.com/bitsandbytes-foundation/bitsandbytes";
changelog = "https://github.com/bitsandbytes-foundation/bitsandbytes/releases/tag/${version}";
changelog = "https://github.com/bitsandbytes-foundation/bitsandbytes/releases/tag/${finalAttrs.src.tag}";
license = lib.licenses.mit;
maintainers = with lib.maintainers; [
bcdarwin
jk
];
};
}
})
Loading