Skip to content

python3Packages.torchtune: skip failing tests on x86_64-linux#482990

Merged
happysalada merged 2 commits into
NixOS:masterfrom
GaetanLepage:torchtune
Jan 25, 2026
Merged

python3Packages.torchtune: skip failing tests on x86_64-linux#482990
happysalada merged 2 commits into
NixOS:masterfrom
GaetanLepage:torchtune

Conversation

@GaetanLepage

@GaetanLepage GaetanLepage commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

Things done

        path = os.fspath(path)  # AOTIModelPackageLoader expects (str, str)
>       loader = torch._C._aoti.AOTIModelPackageLoader(
            path, model_name, run_single_threaded, num_runners, device_index
        )
E       RuntimeError: Error in dlopen: /tmp/YrvJIS/tpe/data/aotinductor/model/c6obodzaot56wszmluag42nfsd46qixeii2siknbrzoxk4iydrpc.wrapper.so: cannot enable executable stack as shared object requires: Invalid argument

device_index = -1
model_name = 'model'
num_runners = 1
path       = '/build/tmpak4zd9oh/tpe.pt2'
run_single_threaded = False
  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot requested a review from sarahec January 23, 2026 09:45
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 23, 2026
@GaetanLepage GaetanLepage requested a review from NickCao January 23, 2026 10:58
@GaetanLepage

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 482990
Commit: ed6b0a3c1a285be898f4ade539aadd61f31e386b


x86_64-linux

✅ 4 packages built:
  • python313Packages.executorch
  • python313Packages.executorch.dist
  • python313Packages.torchtune
  • python313Packages.torchtune.dist

@NickCao

NickCao commented Jan 23, 2026

Copy link
Copy Markdown
Member

So this is caused by aotinductor (from torch) creating so with executable stack, is it possible to fix the root cause?

@GaetanLepage

Copy link
Copy Markdown
Contributor Author

So this is caused by aotinductor (from torch) creating so with executable stack, is it possible to fix the root cause?

That would be great indeed. For now, I have absolutely no idea what would be the underlying cause.
I heavily suspect this being a regression brought by #479279.

If anyone has an idea, please feel free to chime in :)

@happysalada happysalada added this pull request to the merge queue Jan 25, 2026
Merged via the queue into NixOS:master with commit 6ba71cb Jan 25, 2026
31 of 33 checks passed
@GaetanLepage GaetanLepage deleted the torchtune branch January 25, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants