sdl3-image: 3.2.6 -> 3.4.0, fix compilation with stb by evysgarden · Pull Request #482633 · NixOS/nixpkgs

evysgarden · 2026-01-22T09:55:49Z

Update sdl3-image to 3.4.0

Release details: https://github.com/libsdl-org/SDL_image/releases/tag/release-3.4.0

Things done

evysgarden · 2026-01-22T10:05:03Z

running review on x86_64 linux rn

evysgarden · 2026-01-22T10:47:23Z

my internet broke down, so it'll be a few hours

LordGrimmauld · 2026-01-22T10:50:51Z

This is a major release. How much breakage in consumers do you expect? As in, should we backport or not?

evysgarden · 2026-01-22T11:20:02Z

This is a major release. How much breakage in consumers do you expect? As in, should we backport or not?

from what I can see, this version only adds new functionality. I don't think it would break anything

evysgarden · 2026-01-22T11:32:45Z

i changed this to draft for now. it depends on sdl3-3.4.0

evysgarden · 2026-01-22T11:55:05Z

depends on #475854 (currently in staging)

Review dismissed automatically

marcin-serwin · 2026-01-22T18:12:52Z

No point in targeting staging with so few rebuilds, I would just wait for #479279.

it depends on sdl3-3.4.0

In that case it can't be backported to stable since it's still on sdl3-3.2.x. I'm aware of at least one breaking change in sdl-3.4.0 so I wouldn't backport it unless we have a good reason to do so.

evysgarden · 2026-01-22T20:04:40Z

alr, will rebase tmrw

Review dismissed automatically

evysgarden · 2026-01-23T11:08:29Z

~~done rebasing now. sry for all the noise. will wait until 3.4.0 is merged into master now~~

just noticed that sdl3 3.4.0 is in master already. will fix some compilation errors reopen the pull request

evysgarden · 2026-01-23T11:40:41Z

this is not building anymore with the following log from cmake:

> CMake Error at /nix/store/lxkvigfj5xy6w2bs7h4xwr3d7wb7piqb-cmake-4.1.2/share/cmake-4.1/Modules/FindPackageHandleStandardArgs.cmake:227 (message):
>   Could NOT find PNG (missing: PNG_LIBRARY PNG_PNG_INCLUDE_DIR)
> Call Stack (most recent call first):
>   /nix/store/lxkvigfj5xy6w2bs7h4xwr3d7wb7piqb-cmake-4.1.2/share/cmake-4.1/Modules/FindPackageHandleStandardArgs.cmake:591 (_FPHSA_FAILURE_MESSAGE)
>   /nix/store/lxkvigfj5xy6w2bs7h4xwr3d7wb7piqb-cmake-4.1.2/share/cmake-4.1/Modules/FindPNG.cmake:193 (find_package_handle_standard_args)
>   CMakeLists.txt:877 (find_package)

Setting SDLIMAGE_PNG_LIBPNG to false fixes compilation but disables apng support. I'm not quite sure why this is happening.

Will look at it later, gotta eat now. Feel free to look into it.

evysgarden · 2026-01-23T13:31:30Z

fixed it by disabling libpng when stb is used.

evysgarden · 2026-01-23T13:43:23Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 482633
Commit: 8bf0d67e364e4a6ef4e3e45c64ba7d137bfc91ca

`x86_64-linux`

❌ 3 packages failed to build:

brutespray
medusa
medusa.man

✅ 36 packages built:

budgie-control-center
budgie-control-center.debug
crowbar
crowbar.dist
freerdp
gnome-connections
gnome-control-center
gnome-control-center.debug
gnome-remote-desktop
gtk-frdp
guacamole-server
kdePackages.krdc
kdePackages.krdc.debug
kdePackages.krdc.dev
kdePackages.krdc.devtools
kdePackages.krdp
kdePackages.krdp.debug
kdePackages.krdp.dev
kdePackages.krdp.devtools
phosh
phosh-mobile-settings
python313Packages.pysdl3
python313Packages.pysdl3.dist
python314Packages.pysdl3
python314Packages.pysdl3.dist
remmina
sdl3-image
sdl3-image.dev
sdl3-image.lib
tauon
tauon.dist
weston
winboat
x11docker
xwayland-run
xwayland-run.man

Error logs: `x86_64-linux`

medusa

  442 |   pResponseCallback = response_callback;
      |                     ^
ssh.c:398:6: note: 'response_callback' declared here
  398 | void response_callback(const char* name, int name_len, const char* instruction, int instruction_len, int num_prompts, const LIBSSH2_USERAUTH_KBDINT_PROMPT* prompts, LIBSSH2_USERAUTH_KBDINT_RESPONSE* responses, void **abstract)
      |      ^~~~~~~~~~~~~~~~~
ssh.c:495:11: error: passing argument 4 of 'libssh2_userauth_keyboard_interactive_ex' from incompatible pointer type [8;;https://gcc.gnu.org/onlinedocs/gcc-15.2.0/gcc/Warning-Options.html#index-Wincompatible-pointer-types�-Wincompatible-pointer-types8;;�]
  495 |       if (libssh2_userauth_keyboard_interactive(session, szLogin, pResponseCallback) )
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |           |
      |           void (*)(void)
/nix/store/s42wjlhq35xd2yxksiwy2zwj9a4km8nm-libssh2-1.11.1-dev/include/libssh2.h:798:42: note: expected 'void (*)(const char *, int,  const char *, int,  int,  const LIBSSH2_USERAUTH_KBDINT_PROMPT *, LIBSSH2_USERAUTH_KBDINT_RESPONSE *, void **)' but argument is of type 'void (*)(void)'
  798 |                                          LIBSSH2_USERAUTH_KBDINT_RESPONSE_FUNC
      |                                          ^
make[3]: *** [Makefile:781: ssh.o] Error 1
make[3]: Leaving directory '/build/source/src/modsrc'
make[2]: *** [Makefile:418: all-recursive] Error 1
make[2]: Leaving directory '/build/source/src'
make[1]: *** [Makefile:446: all-recursive] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:344: all] Error 2

evysgarden · 2026-01-23T13:45:35Z

the medusa package not building seems unrelated, there's an issue for that here: #481545

jansol

This is indeed a "major" release in terms of new additions but existing API / ABI from previous stable 3.x releases is expected to remain unchanged.

marcin-serwin

this is not building anymore with the following log from cmake:

This is because libpng is now always used for PNG images even with stb backend enabled, see libsdl-org/SDL_image#666.

fixed it by disabling libpng when stb is used.

IMO the correct way is to move libpng to unconditional buildInputs and leave stb enabled to match upstream defaults:

diff --git a/pkgs/by-name/sd/sdl3-image/package.nix b/pkgs/by-name/sd/sdl3-image/package.nix
index 528a06a499..cdce69d3f4 100644
--- a/pkgs/by-name/sd/sdl3-image/package.nix
+++ b/pkgs/by-name/sd/sdl3-image/package.nix
@@ -48,10 +48,10 @@
     libtiff
     libwebp
     libjxl
+    libpng
   ]
   ++ (lib.optional (!stdenv.hostPlatform.isDarwin) libavif)
   ++ (lib.optionals (!enableSTB) [
-    libpng
     libjpeg
   ]);

evysgarden · 2026-01-23T16:52:53Z

@marcin-serwin fair enough, though I'm not sure if we should leave stb enabled by default

marcin-serwin · 2026-01-23T17:20:45Z

The update commit should contain the libpng fix otherwise it doesn't build so it will be harder to bisect in the future.

I'm not sure if we should leave stb enabled by default

The upstream uses stb by default but I don't have a strong opinion on that, up to you.

evysgarden · 2026-01-23T19:26:10Z

squashed to one commit now, will keep stb enabled by default

evysgarden · 2026-01-23T19:42:51Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 482633
Commit: cd9901b04e567ddc48bce63e9f4ef3f2fed9d6a6

`x86_64-linux`

❌ 3 packages failed to build:

brutespray
medusa
medusa.man

✅ 36 packages built:

budgie-control-center
budgie-control-center.debug
crowbar
crowbar.dist
freerdp
gnome-connections
gnome-control-center
gnome-control-center.debug
gnome-remote-desktop
gtk-frdp
guacamole-server
kdePackages.krdc
kdePackages.krdc.debug
kdePackages.krdc.dev
kdePackages.krdc.devtools
kdePackages.krdp
kdePackages.krdp.debug
kdePackages.krdp.dev
kdePackages.krdp.devtools
phosh
phosh-mobile-settings
python313Packages.pysdl3
python313Packages.pysdl3.dist
python314Packages.pysdl3
python314Packages.pysdl3.dist
remmina
sdl3-image
sdl3-image.dev
sdl3-image.lib
tauon
tauon.dist
weston
winboat
x11docker
xwayland-run
xwayland-run.man

Error logs: `x86_64-linux`

medusa

  442 |   pResponseCallback = response_callback;
      |                     ^
ssh.c:398:6: note: 'response_callback' declared here
  398 | void response_callback(const char* name, int name_len, const char* instruction, int instruction_len, int num_prompts, const LIBSSH2_USERAUTH_KBDINT_PROMPT* prompts, LIBSSH2_USERAUTH_KBDINT_RESPONSE* responses, void **abstract)
      |      ^~~~~~~~~~~~~~~~~
ssh.c:495:11: error: passing argument 4 of 'libssh2_userauth_keyboard_interactive_ex' from incompatible pointer type [8;;https://gcc.gnu.org/onlinedocs/gcc-15.2.0/gcc/Warning-Options.html#index-Wincompatible-pointer-types�-Wincompatible-pointer-types8;;�]
  495 |       if (libssh2_userauth_keyboard_interactive(session, szLogin, pResponseCallback) )
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |           |
      |           void (*)(void)
/nix/store/s42wjlhq35xd2yxksiwy2zwj9a4km8nm-libssh2-1.11.1-dev/include/libssh2.h:798:42: note: expected 'void (*)(const char *, int,  const char *, int,  int,  const LIBSSH2_USERAUTH_KBDINT_PROMPT *, LIBSSH2_USERAUTH_KBDINT_RESPONSE *, void **)' but argument is of type 'void (*)(void)'
  798 |                                          LIBSSH2_USERAUTH_KBDINT_RESPONSE_FUNC
      |                                          ^
make[3]: *** [Makefile:781: ssh.o] Error 1
make[3]: Leaving directory '/build/source/src/modsrc'
make[2]: *** [Makefile:418: all-recursive] Error 1
make[2]: Leaving directory '/build/source/src'
make[1]: *** [Makefile:446: all-recursive] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:344: all] Error 2

evysgarden · 2026-01-23T19:43:51Z

the medusa package not building seems unrelated, there's an issue for that here: #481545

.

pbsds · 2026-01-24T16:41:23Z

Thank you!

evysgarden self-assigned this Jan 22, 2026

nixpkgs-ci Bot requested review from LordGrimmauld, jansol, marcin-serwin and pbsds January 22, 2026 10:01

evysgarden added the backport release-25.11 label Jan 22, 2026

evysgarden marked this pull request as draft January 22, 2026 11:26

evysgarden force-pushed the sdl3-image-3.4.0 branch from 4e15f2b to 287a497 Compare January 22, 2026 12:10

evysgarden changed the base branch from master to staging January 22, 2026 12:11

This comment was marked as outdated.

Sign in to view

nixpkgs-ci Bot closed this Jan 22, 2026

nixpkgs-ci Bot reopened this Jan 22, 2026

evysgarden force-pushed the sdl3-image-3.4.0 branch from 287a497 to 371bb7f Compare January 22, 2026 12:12

evysgarden removed the backport release-25.11 label Jan 22, 2026

evysgarden changed the base branch from staging to master January 23, 2026 11:03

nixpkgs-ci Bot closed this Jan 23, 2026

nixpkgs-ci Bot reopened this Jan 23, 2026

This comment was marked as outdated.

Sign in to view

evysgarden force-pushed the sdl3-image-3.4.0 branch from 371bb7f to 0e64cd1 Compare January 23, 2026 11:03

evysgarden marked this pull request as ready for review January 23, 2026 13:45

jansol approved these changes Jan 23, 2026

View reviewed changes

marcin-serwin requested changes Jan 23, 2026

View reviewed changes

nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 23, 2026

evysgarden force-pushed the sdl3-image-3.4.0 branch from 8bf0d67 to e9fc628 Compare January 23, 2026 16:55

evysgarden force-pushed the sdl3-image-3.4.0 branch from e9fc628 to 099ada0 Compare January 23, 2026 19:23

sdl3-image: 3.2.6 -> 3.4.0, fix compilation with stb

cd9901b

evysgarden force-pushed the sdl3-image-3.4.0 branch from 099ada0 to cd9901b Compare January 23, 2026 19:24

evysgarden changed the title ~~sdl3-image: 3.2.6 -> 3.4.0~~ sdl3-image: 3.2.6 -> 3.4.0, fix compilation with stb Jan 23, 2026

marcin-serwin approved these changes Jan 23, 2026

View reviewed changes

nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 23, 2026

pbsds added this pull request to the merge queue Jan 24, 2026

Merged via the queue into NixOS:master with commit 5d2c427 Jan 24, 2026
31 of 33 checks passed

Uh oh!

Uh oh!

Conversation

evysgarden commented Jan 22, 2026

Things done

Uh oh!

evysgarden commented Jan 22, 2026

Uh oh!

evysgarden commented Jan 22, 2026

Uh oh!

LordGrimmauld commented Jan 22, 2026

Uh oh!

evysgarden commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

evysgarden commented Jan 22, 2026

Uh oh!

evysgarden commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

marcin-serwin commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

evysgarden commented Jan 22, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

evysgarden commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

evysgarden commented Jan 23, 2026

Uh oh!

evysgarden commented Jan 23, 2026

Uh oh!

evysgarden commented Jan 23, 2026

nixpkgs-review result

x86_64-linux

Uh oh!

evysgarden commented Jan 23, 2026

Uh oh!

jansol left a comment

Choose a reason for hiding this comment

Uh oh!

marcin-serwin left a comment

Choose a reason for hiding this comment

Uh oh!

evysgarden commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcin-serwin commented Jan 23, 2026

Uh oh!

evysgarden commented Jan 23, 2026

Uh oh!

evysgarden commented Jan 23, 2026

nixpkgs-review result

x86_64-linux

Uh oh!

evysgarden commented Jan 23, 2026

Uh oh!

pbsds commented Jan 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

evysgarden commented Jan 22, 2026 •

edited

Loading

evysgarden commented Jan 22, 2026 •

edited

Loading

marcin-serwin commented Jan 22, 2026 •

edited

Loading

evysgarden commented Jan 23, 2026 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

evysgarden commented Jan 23, 2026 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`