pkgsStatic.onetbb: mark unsupported#471845
Conversation
oneTBB does not support static builds
|
|
Perhaps only need to disable TBB_TEST and check. |
I don't understand what you mean. Are there tests I can run? What's the command? |
uninsane
left a comment
There was a problem hiding this comment.
i'd prefer to rewrite the fix in a way that's eligible for master (i.e. condition the new flags behind isStatic, so as to fix it without triggering any rebuilds for most users), or wait for the next staging -> master merge
so it seems that linking onetbb statically is possible, but it exhibits different behavior such that applications are liable to crash unless they've specifically considered the case of being built against a static onetbb. so defaulting useTBB to false on static platforms seems like the right call.
setting badPlatforms on onetbb itself seems heavy-handed (that causes nix-build -A pkgsStatic.onetbb itself to complain, even though it can be used legitimately), but i can't think of any way to get better ergonomics that isn't significantly more involved.
so... this PR is at least a step in the right direction, i think
|
Successfully created backport PR for |
oneTBB can't be staticly linked.
This obsoletes #468506
This isn't a breaking change;
pkgsStatic.onetbbalready failed to build.This allows building staticly linked nix!
nix build .#pkgsStatic.nixThings done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.