[Reapply] Minor check-meta.nix optimisations and cleanups#471029
Merged
Conversation
- Makes the code more clean and obvious - Allows remediations to depend on values computed during the check (useful for NixOS#338267) Reapplying 42cfcdf after reversal in 0b90ed8 Compared to the original commit, this includes the fix for the problem that required the revert.
1 task
nixpkgs-ci
Bot
requested review from
Artturin,
Ericson2314,
RossComputerGuy,
adisbladis,
emilazy,
philiptaron and
reckenrode
nixpkgs-ci
Bot
added
10.rebuild-darwin: 0
Member
|
Just to be sure, I rechecked nix build -f nixos/release-small.nix nixpkgs.release-checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reapplies #466947 with a fix and another minor change after the reversal in #470757 due to the Hydra error.
Things done
Add a 👍 reaction to pull requests you find important.