Skip to content

cudaPackages.nccl-tests: 2.14.1 -> 2.17.6 #458619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ConnorBaker merged 1 commit into from
Nov 4, 2025
Merged

cudaPackages.nccl-tests: 2.14.1 -> 2.17.6 #458619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions pkgs/development/cuda-modules/packages/nccl-tests.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
let
inherit (_cuda.lib) _mkMetaBroken;
inherit (lib) licenses maintainers teams;
inherit (lib.attrsets) getBin;
inherit (lib.attrsets) getBin getInclude getLib;
inherit (lib.lists) optionals;
in
backendStdenv.mkDerivation (finalAttrs: {
Expand All @@ -30,27 +30,21 @@ backendStdenv.mkDerivation (finalAttrs: {
# NOTE: Depends on the CUDA package set, so use cudaNamePrefix.
name = "${cudaNamePrefix}-${finalAttrs.pname}-${finalAttrs.version}";
pname = "nccl-tests";
version = "2.14.1";
version = "2.17.6";

src = fetchFromGitHub {
owner = "NVIDIA";
repo = "nccl-tests";
rev = "v${finalAttrs.version}";
hash = "sha256-OgffbW9Vx/sm1I1tpaPGdAhIpV4jbB4hJa9UcEAWkdE=";
hash = "sha256-F7F8UcBCX7nsuCNCzWHNY12QFtmYV10Jf785P39SHkM=";
};

postPatch = ''
nixLog "patching $PWD/src/Makefile to remove NVIDIA's ccbin declaration"
substituteInPlace ./src/Makefile \
nixLog "patching $PWD/src/common.mk to remove NVIDIA's ccbin declaration"
substituteInPlace ./src/common.mk \
--replace-fail \
'-ccbin $(CXX)' \
""

nixLog "patching $PWD/src/Makefile to replace -std=c++11 with -std=c++14"
substituteInPlace ./src/Makefile \
--replace-fail \
'-std=c++11' \
'-std=c++14'
'';

nativeBuildInputs = [
Expand All @@ -65,12 +59,15 @@ backendStdenv.mkDerivation (finalAttrs: {
]
++ optionals mpiSupport [ mpi ];

# NOTE: CUDA_HOME is expected to have the bin directory
# TODO: This won't work with cross-compilation since cuda_nvcc will come from hostPackages by default (aka pkgs).
makeFlags = [
# NOTE: CUDA_HOME is expected to have the bin directory
# TODO: This won't work with cross-compilation since cuda_nvcc will come from hostPackages by default (aka pkgs).
"CXXSTD=-std=c++17"
"CUDA_HOME=${getBin cuda_nvcc}"
"NCCL_HOME=${nccl}"
"CUDA_INC=${getInclude cuda_cudart}/include"
"CUDA_LIB=${getLib cuda_cudart}/lib"
"NVCC_GENCODE=${flags.gencodeString}"
"PREFIX=$(out)"
]
++ optionals mpiSupport [ "MPI=1" ];

Expand Down
Loading