Skip to content

cplex & oilrush: fix evaluation errors #457769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
h0nIg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

cplex & oilrush: fix evaluation errors #457769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b90c8db
cplex: fix evaluation errors
h0nIg Nov 2, 2025
eb18ed1
oilrush: fix evaluation errors
h0nIg Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/applications/science/math/cplex/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ stdenv.mkDerivation rec {
mainProgram = "cplex";
sourceProvenance = with sourceTypes; [ binaryNativeCode ];
license = licenses.unfree;
platforms = [ "x86_64-linux" ];
platforms = if releasePath == null then [ ] else [ "x86_64-linux" ];

@wolfgangwalther wolfgangwalther Nov 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this effective leads to the error message never being visible, so users don't know what they need to do to make this work.

@h0nIg h0nIg Nov 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just partially correct, they will be told to

  1. enable unfree software (same as before)
  2. enable unsupported platforms (because they did not specify src)
  3. will see the error message that they need to specify src (same as before)

it would be the same if we use broken = if .... and NIXPKGS_ALLOW_BROKEN=true, what do you think matches most here @wolfgangwalther ?

@wolfgangwalther wolfgangwalther Nov 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that nobody expects to get to useful information after enabling unsupported platforms.

I think this needs meta.problems: NixOS/rfcs#127

maintainers = with maintainers; [ bfortz ];
};
}
8 changes: 3 additions & 5 deletions pkgs/by-name/oi/oilrush/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,13 @@

let
inherit (lib) makeLibraryPath;
url = config.oilrush.url or null;
sha256 = config.oilrush.sha256 or null;
in

stdenv.mkDerivation {
name = "oilrush";
src =
let
url = config.oilrush.url or null;
sha256 = config.oilrush.sha256 or null;
in
assert url != null && sha256 != null;
fetchurl { inherit url sha256; };
shell = stdenv.shell;
Expand Down Expand Up @@ -130,7 +128,7 @@ stdenv.mkDerivation {
'';
homepage = "http://oilrush-game.com/";
license = lib.licenses.unfree;
platforms = lib.platforms.linux;
platforms = if url != null && sha256 != null then lib.platforms.linux else [ ];
hydraPlatforms = [ ];
sourceProvenance = [ lib.sourceTypes.binaryNativeCode ];
};
Expand Down
Loading