various: drop darwin workarounds for infrec

[wolfgangwalther]

I can't cause infinite recursion by dropping these workarounds, so I conclude they're not necessary anymore.

Of course - it could very well be that I just hold it wrong, if that's the case please tell me how to reproduce that infrec :)

These were introduced in #346043, but I can't find reproducers in the commit messages.

Things done

• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[reckenrode]

Do pkgsStatic and pkgsCross to the other Darwin architecture still work?

[wolfgangwalther]

In a nix repl with system aarch64-darwin:

nix-repl> pkgsCross.x86_64-darwin.hello
«derivation /nix/store/jvl6kgxfhm3n794c51xd8l8g7wqxcy9i-hello-x86_64-apple-darwin-2.12.2.drv»

nix-repl> pkgsCross.x86_64-darwin.libxml2
«derivation /nix/store/4rv74m2x1589dq4fvcpa819vndsmshvb-libxml2-x86_64-apple-darwin-2.15.0.drv»

nix-repl> pkgsCross.x86_64-darwin.xcbuild
«derivation /nix/store/m8gph9bxns24h2i824pk220if00b01ks-xcbuild-x86_64-apple-darwin-0.1.1-unstable-2019-11-20.drv»

nix-repl> pkgsCross.x86_64-darwin.libpng
«derivation /nix/store/83w192aj84fiiqz7c1vkrwj2kgdfdk8k-libpng-apng-x86_64-apple-darwin-1.6.50.drv»

nix-repl> pkgsCross.x86_64-darwin.zlib
«derivation /nix/store/sf9n89an04zfa62ff64ipi5006mrd4k9-zlib-x86_64-apple-darwin-1.3.1.drv»

nix-repl> pkgsStatic.hello
«derivation /nix/store/7y1289gw9vzcxdiga5pc71glzh6ck19s-hello-static-arm64-apple-darwin-2.12.2.drv»

nix-repl> pkgsStatic.libxml2
«derivation /nix/store/v563q2wfh42gl5yrv71mq27l5b4mn755-libxml2-static-arm64-apple-darwin-2.15.0.drv»

nix-repl> pkgsStatic.xcbuild
«derivation /nix/store/3zg3f802d4bkcl72kyk7rkc810bi6jw8-xcbuild-static-arm64-apple-darwin-0.1.1-unstable-2019-11-20.drv»

nix-repl> pkgsStatic.libpng
«derivation /nix/store/w6vb0a8mdra02j2z5hsah9awxrr9l2f1-libpng-apng-static-arm64-apple-darwin-1.6.50.drv»

nix-repl> pkgsStatic.zlib
«derivation /nix/store/gy1sry5pjbm1jim6fk2f4f6pdb51k4jr-zlib-static-arm64-apple-darwin-1.3.1.drv»

So yes, both cross to darwin and static seem to work. I also double checked the other direction, i.e. on x86_64-darwin.

I did not do any builds, yet, but if the results so far seem alright, I'd fix the remaining CI issues and do a bootstrap. (Edit: currently building..)

[wolfgangwalther]

I did not do any builds, yet, but if the results so far seem alright, I'd fix the remaining CI issues and do a bootstrap. (Edit: currently building..)

I tried on the community builder, but hit openssl test errors in the sandbox. I gave up, because @emilazy assured me that we don't need rebuilds for this kind of fix. She also mentioned that this is heavily confusing and she would certainly expect infrec here.

[wolfgangwalther]

Any objections to merging this, @emilazy, @reckenrode?