spire: 1.13.1 -> 1.13.2#454565
Merged
Merged
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
Member
|
The PR you link is related to updating to 1.25.2. AFAICT the tests break because of a regression in that version. I'm running a review but I dont think the package will build and tests will pass until go 1.25.3 lands |
Contributor
Author
|
The PR for spire includes changes that I assume work around the regression. 1.13.1 is failing tests in nixpkgs on master and nixos-unstable-small but 1.13.2 works, I'm already running it on a bunch of machines. |
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes test failures introduced by Go 1.25.2: spiffe/spire#6363
Also add myself as a maintainer.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.