Skip to content

nixos/fontconfig: add test for allowBitmaps#450626

Merged
misuzu merged 1 commit into
NixOS:staging-nixosfrom
freshprince:fontconfig-bitmap
Oct 13, 2025
Merged

nixos/fontconfig: add test for allowBitmaps#450626
misuzu merged 1 commit into
NixOS:staging-nixosfrom
freshprince:fontconfig-bitmap

Conversation

@freshprince

Copy link
Copy Markdown
Contributor

To prevent #449657. Test could also be combined with nixos/tests/fontconfig-default-fonts.nix

Cc: @jtojnar

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Oct 10, 2025
@nixpkgs-ci nixpkgs-ci Bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 10, 2025
@misuzu

misuzu commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

Should go to the staging-nixos as well

@misuzu misuzu changed the base branch from master to staging-nixos October 13, 2025 20:23
@nixpkgs-ci nixpkgs-ci Bot closed this Oct 13, 2025
@nixpkgs-ci nixpkgs-ci Bot reopened this Oct 13, 2025

@misuzu misuzu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passes with #450484 and fails without.

@misuzu misuzu merged commit 4bbbac6 into NixOS:staging-nixos Oct 13, 2025
56 of 58 checks passed
@freshprince

Copy link
Copy Markdown
Contributor Author

Thanks for merging!

@freshprince freshprince deleted the fontconfig-bitmap branch October 20, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants