Skip to content

[Backport release-25.05] go_1_25: init at 1.25.1#448882

Merged
katexochen merged 4 commits into
NixOS:release-25.05from
mdaniels5757:backport-go-1.25.to-release-25.05
Oct 6, 2025
Merged

[Backport release-25.05] go_1_25: init at 1.25.1#448882
katexochen merged 4 commits into
NixOS:release-25.05from
mdaniels5757:backport-go-1.25.to-release-25.05

Conversation

@mdaniels5757

@mdaniels5757 mdaniels5757 commented Oct 5, 2025

Copy link
Copy Markdown
Member

Manual backport of #420392 #431616 #433239 #441005 to release-25.05.

I don't touch go, buildGoModule, go_latest, or buildGoLatestModule, and without removing old versions because both of these would be breaking changes.

Related:

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 4.workflow: backport This targets a stable branch labels Oct 5, 2025
zowoq and others added 4 commits October 5, 2025 11:39
(cherry picked from commit 9bbcfea)
(cherry picked from commit b889cee)
(cherry picked from commit eae238e)
(cherry picked from commit f68798a)
@mdaniels5757 mdaniels5757 force-pushed the backport-go-1.25.to-release-25.05 branch from 966f2d1 to 017990d Compare October 5, 2025 15:40

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This report is automatically generated by the PR / Check / cherry-pick CI workflow.

Some of the commits in this PR require the author's and reviewer's attention.

Sometimes it is not possible to cherry-pick exactly the same patch.
This most frequently happens when resolving merge conflicts.
The range-diff will help to review the resolution of conflicts.

If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.

Warning

Difference between e3a3727 and original 9bbcfea may warrant inspection.

Show diff
@@ Metadata
  ## Commit message ##
     go_1_25: init at 1.25rc2
 
+    (cherry picked from commit 9bbcfea275cb154aa753ff794d12cb5214bb8484)
+
  ## pkgs/development/compilers/go/1.25.nix (new) ##
 @@
 +{
@@ pkgs/development/compilers/go/1.25.nix (new)
 +    runHook postBuild
 +  '';
 +
-+  preInstall =
-+    ''
++  preInstall = ''
 +    # Contains the wrong perl shebang when cross compiling,
 +    # since it is not used for anything we can deleted as well.
 +    rm src/regexp/syntax/make_perl_groups.pl

Hint: The full diffs are also available in the runner logs with slightly better highlighting.

@mdaniels5757 mdaniels5757 force-pushed the backport-go-1.25.to-release-25.05 branch from 017990d to e44e4f1 Compare October 5, 2025 15:42
@mdaniels5757

Copy link
Copy Markdown
Member Author

The nixpkgs-vet failure is expected: the check failed on master as well.

The cherry-pick failure is expected too due to the nixfmt 1.0.0 treewide.

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 6, 2025
@katexochen katexochen dismissed github-actions[bot]’s stale review October 6, 2025 10:06

Just a formatting change

@katexochen katexochen enabled auto-merge October 6, 2025 10:06
@katexochen katexochen disabled auto-merge October 6, 2025 14:00
@katexochen katexochen merged commit 3b355c7 into NixOS:release-25.05 Oct 6, 2025
28 of 32 checks passed
@mdaniels5757 mdaniels5757 deleted the backport-go-1.25.to-release-25.05 branch October 6, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants