Skip to content

gdm: fix build with gcc15#446392

Closed
ghpzin wants to merge 1 commit into
NixOS:masterfrom
ghpzin:pr-gdm-gcc15
Closed

gdm: fix build with gcc15#446392
ghpzin wants to merge 1 commit into
NixOS:masterfrom
ghpzin:pr-gdm-gcc15

Conversation

@ghpzin

@ghpzin ghpzin commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Fixes build failure with gcc15:

FAILED: [code=1] common/libgdmcommon.a.p/gdm-settings-utils.c.o
In file included from ../common/gdm-settings-utils.c:38:
../common/gdm-settings-utils.h:47:77: error: expected ';', ',' or ')' before 'bool'
   47 |                                                                 gboolean   *bool);
      |                                                                             ^~~~
../common/gdm-settings-utils.c:290:50: error: expected ';', ',' or ')' before 'bool'
  290 |                                      gboolean   *bool)
      |                                                  ^~~~
...
FAILED: [code=1] common/libgdmcommon.a.p/gdm-settings-direct.c.o
In file included from ../common/gdm-settings-direct.c:38:
../common/gdm-settings-utils.h:47:77: error: expected ';', ',' or ')' before 'bool'
   47 |                                                                 gboolean   *bool);
      |                                                                             ^~~~
../common/gdm-settings-direct.c: In function 'gdm_settings_direct_get_boolean':
../common/gdm-settings-direct.c:159:15: error: implicit declaration of function
'gdm_settings_parse_value_as_boolean'; did you mean
'gdm_settings_parse_value_as_double'? [-Wimplicit-function-declaration]
  159 |         ret = gdm_settings_parse_value_as_boolean  (str, value);
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |               gdm_settings_parse_value_as_double

Tested build with:

nix-build --expr 'with import ./. {}; gdm.override { stdenv = gcc15Stdenv; }'

Part of fixes for gcc15 update:
#440456

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

- add patch from merged upstream MR:
https://gitlab.gnome.org/GNOME/gdm/-/merge_requests/273

Fixes build failure with gcc15:
```
FAILED: [code=1] common/libgdmcommon.a.p/gdm-settings-utils.c.o
In file included from ../common/gdm-settings-utils.c:38:
../common/gdm-settings-utils.h:47:77: error: expected ';', ',' or ')' before 'bool'
   47 |                                                                 gboolean   *bool);
      |                                                                             ^~~~
../common/gdm-settings-utils.c:290:50: error: expected ';', ',' or ')' before 'bool'
  290 |                                      gboolean   *bool)
      |                                                  ^~~~
...
FAILED: [code=1] common/libgdmcommon.a.p/gdm-settings-direct.c.o
In file included from ../common/gdm-settings-direct.c:38:
../common/gdm-settings-utils.h:47:77: error: expected ';', ',' or ')' before 'bool'
   47 |                                                                 gboolean   *bool);
      |                                                                             ^~~~
../common/gdm-settings-direct.c: In function 'gdm_settings_direct_get_boolean':
../common/gdm-settings-direct.c:159:15: error: implicit declaration of function
'gdm_settings_parse_value_as_boolean'; did you mean
'gdm_settings_parse_value_as_double'? [-Wimplicit-function-declaration]
  159 |         ret = gdm_settings_parse_value_as_boolean  (str, value);
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |               gdm_settings_parse_value_as_double
```
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Sep 26, 2025
@ghpzin

ghpzin commented Sep 26, 2025

Copy link
Copy Markdown
Contributor Author

Merged commit is in 49.rc tag.
gdm should be updated to it in:
#440720
4c1a2f5
Will keep it in draft for now, in case something changes.

@ghpzin

ghpzin commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

#440720 was merged with gdm update

@ghpzin ghpzin closed this Nov 4, 2025
@ghpzin ghpzin deleted the pr-gdm-gcc15 branch November 4, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant