Skip to content

opentelemetry-cpp: fix CMake target include dirs#442584

Merged
pbsds merged 1 commit into
NixOS:masterfrom
algorithmiker:fix-otel
Sep 13, 2025
Merged

opentelemetry-cpp: fix CMake target include dirs#442584
pbsds merged 1 commit into
NixOS:masterfrom
algorithmiker:fix-otel

Conversation

@algorithmiker

@algorithmiker algorithmiker commented Sep 13, 2025

Copy link
Copy Markdown
Member

This broke any library depending on opentelemetry-cpp; but nixpkgs-review didn't catch this because there are no in-tree deps yet (pending #435928).

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Footnotes

  1. or rather the slightly modified version of it from 390485.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 13, 2025
@nix-owners nix-owners Bot requested a review from jfroche September 13, 2025 10:28
Co-Authored-By: Tobias Mayer <tobim@fastmail.fm>
@pbsbot

pbsbot commented Sep 13, 2025

Copy link
Copy Markdown

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 442584
Commit: 8fd6d01f7e0b8938b7af84456c79243263488108


x86_64-linux

✅ 2 packages built:
  • opentelemetry-cpp
  • opentelemetry-cpp.dev

@pbsds

pbsds commented Sep 13, 2025

Copy link
Copy Markdown
Member

Thanks for noticing and following up on this! I was a bit too quick when merging that, assuming it was a dropped postPatch which no longer applied.

@pbsds pbsds added this pull request to the merge queue Sep 13, 2025
Merged via the queue into NixOS:master with commit 4043db5 Sep 13, 2025
30 of 32 checks passed
@panicgh

panicgh commented Sep 13, 2025

Copy link
Copy Markdown
Contributor

Thanks for fixing. I explained the mistake in the discussion at #440194 (comment).

@algorithmiker

Copy link
Copy Markdown
Member Author

That was very fast, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants