opentelemetry-cpp: fix CMake target include dirs#442584
Merged
Merged
Conversation
13 tasks
Co-Authored-By: Tobias Mayer <tobim@fastmail.fm>
ddf0fdd to
8fd6d01
Compare
|
Member
|
Thanks for noticing and following up on this! I was a bit too quick when merging that, assuming it was a dropped |
Contributor
|
Thanks for fixing. I explained the mistake in the discussion at #440194 (comment). |
Member
Author
|
That was very fast, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This broke any library depending on opentelemetry-cpp; but nixpkgs-review didn't catch this because there are no in-tree deps yet (pending #435928).
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.
Footnotes
or rather the slightly modified version of it from 390485. ↩