lixPackageSets.lix_2_90: drop#439941
Merged
Merged
Conversation
lix_2_90 has been marked insecure since 2025-06-24 due to two CVEs. It fails to build with error: 'lowdown_opts' has no non-static data member named 'cols'
nixpkgs-ci
Bot
added
10.rebuild-darwin: 0
lf-
approved these changes
Sep 3, 2025
lf-
left a comment
lf-
left a comment
Member
There was a problem hiding this comment.
yup. there is likely even more junk that can be removed from the common code that's conditional on version btw.
but i don't think we're gonna fix the build of 2.90 so this change seems reasonable to me.
nixpkgs-ci
Bot
added
12.approvals: 1
alois31
approved these changes
Sep 4, 2025
alois31
left a comment
alois31
left a comment
Contributor
There was a problem hiding this comment.
We already have #426260 that also drops 2.91. However the 2.91 removal is more controversial so splitting seems fine. I think #426260 (comment) can also apply to the junk Jade mentioned so this is fine as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lix_2_90 has been marked insecure since 2025-06-24 due to two CVEs.
It now fails to build with
error: 'lowdown_opts' has no non-static data member named 'cols'I don't see any need to keep a broken insecure version of lix around. If there is a need the build should be fixed, and this can be closed.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.